-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Only forward debugger ports when debug components are used #54051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 1 commit into
apache:main
from
potiuk:remove-docker-compose-warning-on-debugger-vars
Aug 2, 2025
Merged
Only forward debugger ports when debug components are used #54051
potiuk
merged 1 commit into
apache:main
from
potiuk:remove-docker-compose-warning-on-debugger-vars
Aug 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc: @rawwar -> small improvement to debug framework. Removes those warnings:
|
When debugger option has been added to breeze in apache#51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
c0afb56 to
1899bb2
Compare
gopidesupavan
approved these changes
Aug 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 2, 2025
#54051) When debugger option has been added to breeze in #51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used. (cherry picked from commit 939700f) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Aug 2, 2025
#54051) (#54053) When debugger option has been added to breeze in #51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used. (cherry picked from commit 939700f) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
aritra24
approved these changes
Aug 2, 2025
Collaborator
aritra24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
) When debugger option has been added to breeze in apache#51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
) When debugger option has been added to breeze in apache#51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

When debugger option has been added to breeze in #51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used.
Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.