Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Aug 2, 2025

When debugger option has been added to breeze in #51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used.

Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Aug 2, 2025
@potiuk potiuk marked this pull request as ready for review August 2, 2025 16:28
@potiuk potiuk requested review from aritra24 and rawwar August 2, 2025 16:28
@potiuk
Copy link
Member Author

potiuk commented Aug 2, 2025

cc: @rawwar -> small improvement to debug framework.

Removes those warnings:

Screenshot 2025-08-02 at 18 28 57

@potiuk potiuk changed the title Only forward debugger ports when debug comoonents are used Only forward debugger ports when debug components are used Aug 2, 2025
When debugger option has been added to breeze in apache#51763 - the ports were added
to base-port.yml, but the environment variables were only set when debugging is
enabled. This hower caused warnings that the variables are not set and
defaulting them to empty string when no debug components were used.

Instead - we moved the debugger ports to separate compose file and
only use the compose file when debug components are used.
@potiuk potiuk force-pushed the remove-docker-compose-warning-on-debugger-vars branch from c0afb56 to 1899bb2 Compare August 2, 2025 16:29
@potiuk potiuk merged commit 939700f into apache:main Aug 2, 2025
99 checks passed
@potiuk potiuk deleted the remove-docker-compose-warning-on-debugger-vars branch August 2, 2025 17:02
github-actions bot pushed a commit that referenced this pull request Aug 2, 2025
#54051)

When debugger option has been added to breeze in #51763 - the ports were added
to base-port.yml, but the environment variables were only set when debugging is
enabled. This hower caused warnings that the variables are not set and
defaulting them to empty string when no debug components were used.

Instead - we moved the debugger ports to separate compose file and
only use the compose file when debug components are used.
(cherry picked from commit 939700f)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link

github-actions bot commented Aug 2, 2025

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

potiuk added a commit that referenced this pull request Aug 2, 2025
#54051) (#54053)

When debugger option has been added to breeze in #51763 - the ports were added
to base-port.yml, but the environment variables were only set when debugging is
enabled. This hower caused warnings that the variables are not set and
defaulting them to empty string when no debug components were used.

Instead - we moved the debugger ports to separate compose file and
only use the compose file when debug components are used.
(cherry picked from commit 939700f)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Copy link
Collaborator

@aritra24 aritra24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
)

When debugger option has been added to breeze in apache#51763 - the ports were added
to base-port.yml, but the environment variables were only set when debugging is
enabled. This hower caused warnings that the variables are not set and
defaulting them to empty string when no debug components were used.

Instead - we moved the debugger ports to separate compose file and
only use the compose file when debug components are used.
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
)

When debugger option has been added to breeze in apache#51763 - the ports were added
to base-port.yml, but the environment variables were only set when debugging is
enabled. This hower caused warnings that the variables are not set and
defaulting them to empty string when no debug components were used.

Instead - we moved the debugger ports to separate compose file and
only use the compose file when debug components are used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants