[v3-0-test] Improve terminal handling for breeze commands (#52452) #52456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Console width has been hard-coded in CI commands, which often limited what was written in CI (Github action's CI does not have a terminal, nor terminal width so we allocate pseudo-terminal there) However when running breeze locally we should be able to use all terminal width. This PR: * increases length of CI terminal as we tend to have longer paths now after we moved stuff to subdirectories * only fixes terminal size on CI and leaves it None (auto) for local runs * adds --tty (default auto) to `breeze run` command to allow to use it both locally and in CI. (cherry picked from commit 3347e03) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
removed
the
backport-to-v3-1-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console width has been hard-coded in CI commands, which often limited what was written in CI (Github action's CI does not have a terminal, nor terminal width so we allocate pseudo-terminal there) However when running breeze locally we should be
able to use all terminal width.
This PR:
breeze runcommand to allow to use it both locally and in CI. (cherry picked from commit 3347e03)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.