Dev: Fix KeyError in release issue content generation #52751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating issue content for releases, some PRs were being filtered out during processing (e.g., dependabot PRs, doc-only PRs) but still remained in the `pull_requests` dictionary. This caused a `KeyError` when the Jinja2 template tried to access `user_logins` for PRs that had no corresponding user data. The fix ensures that `pr_list` variable only contains PRs that have corresponding entries in the users dictionary, preventing the template from accessing undefined keys. Fixes issue where `breeze release-management generate-issue-content-core` command failed with "UndefinedError: dict object has no element <PR_NUMBER>".
kaxil
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
gopidesupavan
approved these changes
Jul 2, 2025
potiuk
approved these changes
Jul 2, 2025
amoghrajesh
approved these changes
Jul 3, 2025
eladkal
approved these changes
Jul 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
…2751) When generating issue content for releases, some PRs were being filtered out during processing (e.g., dependabot PRs, doc-only PRs) but still remained in the `pull_requests` dictionary. This caused a `KeyError` when the Jinja2 template tried to access `user_logins` for PRs that had no corresponding user data. The fix ensures that `pr_list` variable only contains PRs that have corresponding entries in the users dictionary, preventing the template from accessing undefined keys. Fixes issue where `breeze release-management generate-issue-content-core` command failed with "UndefinedError: dict object has no element <PR_NUMBER>". (cherry picked from commit 19da281) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 3, 2025
…ache#52751) When generating issue content for releases, some PRs were being filtered out during processing (e.g., dependabot PRs, doc-only PRs) but still remained in the `pull_requests` dictionary. This caused a `KeyError` when the Jinja2 template tried to access `user_logins` for PRs that had no corresponding user data. The fix ensures that `pr_list` variable only contains PRs that have corresponding entries in the users dictionary, preventing the template from accessing undefined keys. Fixes issue where `breeze release-management generate-issue-content-core` command failed with "UndefinedError: dict object has no element <PR_NUMBER>". (cherry picked from commit 19da281) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
Jul 12, 2025
…2751) When generating issue content for releases, some PRs were being filtered out during processing (e.g., dependabot PRs, doc-only PRs) but still remained in the `pull_requests` dictionary. This caused a `KeyError` when the Jinja2 template tried to access `user_logins` for PRs that had no corresponding user data. The fix ensures that `pr_list` variable only contains PRs that have corresponding entries in the users dictionary, preventing the template from accessing undefined keys. Fixes issue where `breeze release-management generate-issue-content-core` command failed with "UndefinedError: dict object has no element <PR_NUMBER>". (cherry picked from commit 19da281) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
Jul 12, 2025
…2751) (#52756) When generating issue content for releases, some PRs were being filtered out during processing (e.g., dependabot PRs, doc-only PRs) but still remained in the `pull_requests` dictionary. This caused a `KeyError` when the Jinja2 template tried to access `user_logins` for PRs that had no corresponding user data. The fix ensures that `pr_list` variable only contains PRs that have corresponding entries in the users dictionary, preventing the template from accessing undefined keys. Fixes issue where `breeze release-management generate-issue-content-core` command failed with "UndefinedError: dict object has no element <PR_NUMBER>". (cherry picked from commit 19da281) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating issue content for releases, some PRs were being filtered out during processing (e.g., dependabot PRs, doc-only PRs) but still remained in the
pull_requestsdictionary. This caused aKeyErrorwhen the Jinja2 template tried to accessuser_loginsfor PRs that had no corresponding user data.The fix ensures that
pr_listvariable only contains PRs that have corresponding entries in the users dictionary, preventing the template from accessing undefined keys.Fixes issue where
breeze release-management generate-issue-content-corecommand failed with "UndefinedError: dict object has no element <PR_NUMBER>".Error (before the fix):
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.