[v3-0-test] Dev: Fix KeyError in release issue content generation (#52751) #52756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
kaxil
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
amoghrajesh
approved these changes
Jul 3, 2025
kaxil
force-pushed
the
v3-0-test
branch
5 times, most recently
from
0044ec7 to
19b81f6
Compare
kaxil
force-pushed
the
v3-0-test
branch
2 times, most recently
from
61f3916 to
c57bd9c
Compare
Contributor
|
This is not important for v3.0 |
Member
But it's used for airlfow releases as well |
potiuk
approved these changes
Jul 12, 2025
…2751) When generating issue content for releases, some PRs were being filtered out during processing (e.g., dependabot PRs, doc-only PRs) but still remained in the `pull_requests` dictionary. This caused a `KeyError` when the Jinja2 template tried to access `user_logins` for PRs that had no corresponding user data. The fix ensures that `pr_list` variable only contains PRs that have corresponding entries in the users dictionary, preventing the template from accessing undefined keys. Fixes issue where `breeze release-management generate-issue-content-core` command failed with "UndefinedError: dict object has no element <PR_NUMBER>". (cherry picked from commit 19da281) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
potiuk
force-pushed
the
backport-19da281-v3-0-test
branch
from
01b95ee to
90e5660
Compare
Contributor
Not from main? |
eladkal
approved these changes
Jul 12, 2025
Member
Yes when release is prepared all breeze commands are run from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating issue content for releases, some PRs were being filtered out
during processing (e.g., dependabot PRs, doc-only PRs) but still remained in
the
pull_requestsdictionary. This caused aKeyErrorwhen the Jinja2 templatetried to access
user_loginsfor PRs that had no corresponding user data.The fix ensures that
pr_listvariable only contains PRs that have corresponding entriesin the users dictionary, preventing the template from accessing undefined keys.
Fixes issue where
breeze release-management generate-issue-content-corecommand failed with "UndefinedError: dict object has no element <PR_NUMBER>".
(cherry picked from commit 19da281)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com