Airflow-UI - LimitedItemsList: Add separator when only one remaining item is left #52765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkismavridis
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
eladkal
added
the
backport-to-v3-1-test
alkismavridis
commented
Jul 3, 2025
| remainingItems.length === 1 ? ( | ||
| <Text as="span">{remainingItems[0]}</Text> | ||
| <> | ||
| <Text as="span">{separator}</Text> |
Contributor
Author
There was a problem hiding this comment.
I find it weird that line 64 does not give the separator already. The condition on line 63 should be true 🤔
When I manager to run it locally I will be able to dive deeper into the issue.
EDIT:
Is it possible that this is already fixed after 3.0.1? The code seems right.
If so I am really sorry for the trouble and will close this PR.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: 52764
related: 52764
Hint: please do not merge yet, I want to manually test it. I need to figure out how to run airflow locally. Never done it before :) Any hints or resources are most welcome.
I detected the issue in the Tags table (dags page) when there are exactly 4 tags. More or less than 4 is OK.
