Skip to content

Airflow-UI - LimitedItemsList: Add separator when only one remaining item is left #52765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alkismavridis wants to merge 4 commits into from
Closed

Airflow-UI - LimitedItemsList: Add separator when only one remaining item is left #52765

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34626e9
Add http-only warning in documentation
Jul 1, 2025
733114d
Add empty line
Jul 1, 2025
128d02f
Merge branch 'apache:main' into main
alkismavridis Jul 3, 2025
99061ab
Add separater when one remaining item is left
Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airflow-core/src/airflow/ui/src/components/LimitedItemsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ export const LimitedItemsList = ({
))}
{shouldTruncate ? (
remainingItems.length === 1 ? (
<Text as="span">{remainingItems[0]}</Text>
<>
<Text as="span">{separator}</Text>
Copy link
Contributor Author

@alkismavridis alkismavridis Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it weird that line 64 does not give the separator already. The condition on line 63 should be true 🤔
When I manager to run it locally I will be able to dive deeper into the issue.

EDIT:
Is it possible that this is already fixed after 3.0.1? The code seems right.
If so I am really sorry for the trouble and will close this PR.

<Text as="span">{remainingItems[0]}</Text>
</>
) : (
<Tooltip content={remainingItemsList} interactive={interactive}>
<Text as="span" cursor="help">
Expand Down