Fix log for skipped tasks #53024
Merged
Fix log for skipped tasks #53024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
pierrejeambrun
added
the
backport-to-v3-1-test
kaxil
approved these changes
Jul 8, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
(cherry picked from commit 0d6e417) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 8, 2025
(cherry picked from commit 0d6e417) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
bbovenzi
pushed a commit
that referenced
this pull request
Jul 8, 2025
jscheffl
reviewed
Jul 8, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 9, 2025
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Jul 10, 2025
stephen-bracken
pushed a commit
to stephen-bracken/airflow
that referenced
this pull request
Jul 15, 2025
Contributor
|
@pierrejeambrun Besides the implementation in case of "skip" just realized that the same yields for "upstream failed" (and are there more states which will not execute a task?). Also in "upstream failed" no logs are produced and showing them presents an error: Cases where logs are also missing:
|
Member
Author
|
Yes it would be cool to improve that and take all other states into consideration. At least it's not crashing the UI anymore, that could be a nice follow up indeed. |
Member
Author
|
I'll create an issue for that for tracking purpose |
1 task
Member
Author
|
Issue there #53633 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #53002
Following: #51592 we are now filtering on the
try_number.Skipped task have a try number of 0 and UI was defaulting to 1, the skipped task couldn't be found and this cause the 404. Before that related PR, we would find the TI, and request to fetch logs with try_number 1 for a Skipped tasks, that would end up in an invalid url, without hostname, which wasn't great either something like this:
Only the
Empty Operatorhad a special case handling:Now the UI tries to fetch the
TaskInstance.try_number, even if this means that try_number is 0 because the TaskInstance.state is 'skipped'. Allow the backend to take0as a value. The TI will be found and thelog_readerwill then try to read log and return early with a validation check:This is enough to not make the UI not crash. And display a useful message. That's for core log reader. Other log reader will fail with a simple "Error fetching the logs. Try number {try_number} is invalid." (google cloud logs) or any other check implemented in the provider.
We could probably also do this in the google provider, to give a better message. (Separate PR because it's provider related)