Refactoring get con part dbapihook in providers #53335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
kyungjunleeme
changed the title
Contributor
Author
|
@jscheffl Thanks to ur pr review, I think that this refactoring can be helpful. :) |
kyungjunleeme
force-pushed
the
refactor/get_conn_dbapihook_in_providers
branch
from
c9ca77e to
58df219
Compare
jscheffl
approved these changes
Jul 14, 2025
Contributor
|
Cool! |
prdai
pushed a commit
to prdai/airflow
that referenced
this pull request
Jul 15, 2025
* CHG: get_connection in redshift_sql * CHG: get_connection in exasolhook * CHG: get_connection in sqlite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on
#53241
and
#53311,
I identified some areas that would benefit from refactoring,
as maintaining consistency in the codebase helps improve maintainability.
As for #53302,
it already reflects the changes I was planning to make, so I decided to skip that part.
Align with other providers by using get_conn_id() instead of direct attribute access
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.