Skip to content

Refactoring get con part dbapihook in providers #53335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 3 commits into from
Jul 14, 2025
Merged

Refactoring get con part dbapihook in providers #53335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
167ec9a
CHG: get_connection in redshift_sql
kyungjunleeme Jul 14, 2025
6bd5109
CHG: get_connection in exasolhook
kyungjunleeme Jul 14, 2025
58df219
CHG: get_connection in sqlite
kyungjunleeme Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def get_ui_field_behaviour(cls) -> dict:

@cached_property
def conn(self):
return self.get_connection(self.redshift_conn_id)
return self.get_connection(self.get_conn_id())

def _get_conn_params(self) -> dict[str, str | int]:
"""Retrieve connection parameters."""
Expand Down
3 changes: 1 addition & 2 deletions providers/exasol/src/airflow/providers/exasol/hooks/exasol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ def __init__(self, *args, **kwargs) -> None:
self.schema = kwargs.pop("schema", None)

def get_conn(self) -> ExaConnection:
conn_id = self.get_conn_id()
conn = self.get_connection(conn_id)
conn = self.get_connection(self.get_conn_id())
conn_args = {
"dsn": f"{conn.host}:{conn.port}",
"user": conn.login,
Expand Down
3 changes: 1 addition & 2 deletions providers/sqlite/src/airflow/providers/sqlite/hooks/sqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ def get_conn(self) -> sqlite3.dbapi2.Connection:

def get_uri(self) -> str:
"""Override DbApiHook get_uri method for get_sqlalchemy_engine()."""
conn_id = self.get_conn_id()
airflow_conn = self.get_connection(conn_id)
airflow_conn = self.get_connection(self.get_conn_id())
if airflow_conn.conn_type is None:
airflow_conn.conn_type = self.conn_type
airflow_uri = unquote(airflow_conn.get_uri())
Expand Down