Skip to content

Conversation

@gopidesupavan
Copy link
Member

@gopidesupavan gopidesupavan commented Jul 16, 2025

We are planing another activity after mypy bump, to see if any unreachable code warns and fix them. This pr helps to this #53395 to enable community unreachable argument and fix if any real issues


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 16, 2025
@gopidesupavan
Copy link
Member Author

Will announce this activity after thie merge

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK for me. But options are growing. Does it maybe makes sense to consolidate the ENV to "SHOW_WARNINGS" only and apply the env to both parameters?

Besides this the ENV is only known if you read the source, would it be preferrable to add an arg to CLI entry point? Or is it an in-official entry as actually target is to call indirectly via pre-commit only? We could also make a pre-commit manual stage out of it, then it might be easier to find?

Not blocking comments, just ideas.

@gopidesupavan
Copy link
Member Author

Looks OK for me. But options are growing. Does it maybe makes sense to consolidate the ENV to "SHOW_WARNINGS" only and apply the env to both parameters?

Besides this the ENV is only known if you read the source, would it be preferrable to add an arg to CLI entry point? Or is it an in-official entry as actually target is to call indirectly via pre-commit only? We could also make a pre-commit manual stage out of it, then it might be easier to find?

Not blocking comments, just ideas.

Make sense :), i will get it into separate PR..

@gopidesupavan gopidesupavan merged commit fae7590 into apache:main Jul 16, 2025
48 checks passed
@gopidesupavan gopidesupavan deleted the update-mypy-folder-script branch July 16, 2025 17:24
github-actions bot pushed a commit that referenced this pull request Jul 16, 2025
…53398)

(cherry picked from commit fae7590)

Co-authored-by: GPK <gopidesupavan@gmail.com>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 16, 2025
…pache#53398)

(cherry picked from commit fae7590)

Co-authored-by: GPK <gopidesupavan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants