-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix unreachable code mypy warnings in amazon provider #53414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gopidesupavan
merged 2 commits into
apache:main
from
gopidesupavan:remove-or-fix-unreachable-code-in-aws-provider
Jul 16, 2025
Merged
Fix unreachable code mypy warnings in amazon provider #53414
gopidesupavan
merged 2 commits into
apache:main
from
gopidesupavan:remove-or-fix-unreachable-code-in-aws-provider
Jul 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
reviewed
Jul 16, 2025
Member
Author
|
FYI for amazon provider mypy flagged these: |
vincbeck
approved these changes
Jul 16, 2025
jscheffl
approved these changes
Jul 16, 2025
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jscheffl and Me were discussing on mypy unreachable code warnings, we scanned through all the providers and found around 120 warnings, there could be some false positives. I have drafted all those warnings here #53395.
In this PR, will be fixing some of AWS provider warnings, that are make sense to fix. and this will help reference PR to people who works on the created issues.
Will be sending out devlist about this work, once it merged #53398
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.