Skip to content

Conversation

@CincyBC
Copy link
Contributor

@CincyBC CincyBC commented Jul 16, 2025

The AWS Provider Transfer operator, SqlToS3Operator allows for Pandas kwargs to be passed to the write function, but not to the get_df()/read_sql() function. This PR adds a new parameter to the operator called read_pd_kwargs that takes a dictionary and unpacks the dictionary in the get_df function. The get_df method in the DbApiHook allows for kwargs to be passed through and unpacks them in read_sql(). I enhanced the unit tests for csv/parquet with the read_pd_kwargs parameter and made sure it was unpacked successfully.

There is functionality in the operator to fix Numpy data types, which aren't necessary if the dtype_backend is set to 'pyarrow', so I created a conditional to only run the method if 'dtype_backend': 'pyarrow' is not found in the read_pd_kwargs. I added a unit test to ensure the _fix_dtype method is NOT called when the pyarrow backend kwarg is present.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jul 16, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 16, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit bdd4708 into apache:main Jul 18, 2025
77 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 18, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants