Update SqlToS3Operator to support Polars and deprecate read_pd_kwargs #54195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
guan404ming
force-pushed
the
sqltos3-polars
branch
from
7c801e5 to
b6f016a
Compare
eladkal
reviewed
Aug 6, 2025
providers/amazon/src/airflow/providers/amazon/aws/transfers/sql_to_s3.py
Show resolved
Hide resolved
guan404ming
force-pushed
the
sqltos3-polars
branch
2 times, most recently
from
d1c00c9 to
534761a
Compare
vincbeck
reviewed
Aug 7, 2025
providers/amazon/src/airflow/providers/amazon/aws/transfers/sql_to_s3.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/transfers/sql_to_s3.py
Outdated
Show resolved
Hide resolved
guan404ming
force-pushed
the
sqltos3-polars
branch
from
534761a to
0ad88af
Compare
vincbeck
approved these changes
Aug 8, 2025
eladkal
reviewed
Aug 17, 2025
Comment on lines
+258
to
+259
| if isinstance(df, pl.DataFrame): | ||
| df = df.to_pandas() |
Contributor
There was a problem hiding this comment.
@guan404ming Taking a closer look. Is this right?
This means that user who uses polars must also install pandas.
Member
Author
There was a problem hiding this comment.
You're right, to_pandas() still need pandas installed. That means it need re-implementation for this function for supporting two libs differently and I would open a PR for it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR
#53399
cc @eladkal
Why
How
read_pd_kwargs→read_kwargsfor library-agnostic namingdf_typeparameter supporting "pandas" (default) and "polars"_partition_dataframe()to handle both DataFrame types^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.