Skip to content

Conversation

@kyungjunleeme
Copy link
Contributor

@kyungjunleeme kyungjunleeme commented Jul 17, 2025

#53455
#52869

  • Added two unit tests to verify that sensor tasks are properly included in the output of _ensure_tasks() when placed downstream of ShortCircuitOperator.
  • One test uses a custom BaseSensorOperator-based sensor (SucceedingSensor) to simulate success.
  • The second test verifies behavior with the built-in S3KeySensor, testing both deferrable and non-deferrable modes.
  • Both tests assert that the sensor task is not skipped or filtered out by _ensure_tasks() and that it is an instance of SDKBaseOperator.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@kyungjunleeme
Copy link
Contributor Author

file location is can be moved (if everyone wants)

@kyungjunleeme
Copy link
Contributor Author

I'm closing this PR because the test I wrote isn't in the most appropriate location. I think it would be better to add more diverse test cases within the existing test module where similar tests already exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant