Add tests for deferrable sensor behavior with ShortCircuitOperator and _ensure_tasks#53483
Add tests for deferrable sensor behavior with ShortCircuitOperator and _ensure_tasks#53483kyungjunleeme wants to merge 2 commits intoapache:mainfrom
Conversation
kaxil
left a comment
There was a problem hiding this comment.
There is no value in testing deferrable for Shortcircuit separately imo
|
You're right that the root cause was not the deferrable flag itself, but the type mismatch in |
I'll have to respectfully disagree. That will be a redundant test. |
|
Thank you for your feedback. I completely understand your perspective, and I fully respect your decision to close the PR on the grounds that the test appears redundant at this point. That said, I personally see potential value in retaining such a test as a regression safeguard—especially considering the subtle interplay between SDK operator typing and future changes in version logic. I'd like to take some time to investigate this further and better understand whether it truly adds no additional value. If I uncover anything meaningful, I’ll be sure to share it respectfully for further discussion. |
This PR adds the following tests to verify the correct handling of deferrable sensors:
test_short_circuit_operator_skips_deferrable_sensorstest_ensure_tasks_includes_deferrable_sensors_airflow_3xThese tests are a follow-up to #53455 and focus specifically on validating deferrable sensor behavior to ensure consistency with non-deferrable operators.
closes #53461
related with #52869
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.