Skip to content

Conversation

@kyungjunleeme
Copy link
Contributor

@kyungjunleeme kyungjunleeme commented Jul 22, 2025

I'm working on this #53597. I found bug.
this files scope is narrow. it didn't working pre-commit hook.

.
├── __init__.py
├── datamodels
├── middleware.py
├── openapi  # ADD
├── routes  # ADD
├── services  # ADD
├── simple_auth_manager.py
├── ui
└── user.py

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 22, 2025
@kyungjunleeme kyungjunleeme force-pushed the fix/pre-commit-generate-airflowctl-datamodels branch from b15dd0c to 6dc2fd5 Compare July 22, 2025 11:20
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True.

@potiuk potiuk merged commit 6572e2c into apache:main Jul 22, 2025
56 checks passed
@github-actions
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 6572e2c v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@bugraoz93
Copy link
Contributor

Thanks @kyungjunleeme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants