Change logic in auth with swagger ui #53597

kyungjunleeme · 2025-07-21T15:24:32Z

Descritpion

422 root cause related with this https://github.com/fastapi/fastapi/issues/1431

first)
I added this logic to manually convert the request body to a LoginBody instance when it’s received as a dictionary (e.g., from application/x-www-form-urlencoded).

changed my mind)
I think that airflow needs to support both application/json and application/x-www-form-urlencoded content types.

This helps prevent FastAPI from raising a 422 Unprocessable Entity error due to automatic validation failure.

#53567 related. (first this pr merged -> 53597)

"Using the RequestBody option in Swagger UI causes a 422 error."

- "Only accept application/json content-type"

- swagger UI

Result

- Requestbody

- Authroization header

- content-type: application/json, application/x-www-form-urlencoded

cf) https://github.com/koxudaxi/datamodel-code-generator

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

vincbeck

Nice! Can you update tests to cover that?

kyungjunleeme · 2025-07-22T05:16:31Z

I found CI bug. -> I will make 2 PR

id: generate-airflowctl-datamodels FIX - pre-commit scope (generate-airflowctl-datamodels) #53624

id: ts-compile-lint-simple-auth-manager-ui Change pre-commit propety(v1) #53636

ashb

Please check out the settings we have in the Execution API sub-application.

airflow-core/src/airflow/api_fastapi/auth/managers/simple/routes/login.py

kyungjunleeme · 2025-07-22T23:36:07Z

Reflections on the Feedback and Purpose of the PR

After receiving the feedback yesterday, I spent some time reflecting on Airflow's philosophy and current internal structure.
It helped me understand the intention behind the feedback more clearly.

From my perspective, there seems to be a distinction between the authentication mechanisms used for user-facing APIs and those used internally between components within Airflow.

The reason I created this PR was to improve the developer experience for users interacting with the Airflow API through Swagger UI, making it easier to test and trigger endpoints directly.

During this process, I noticed that a 422 Unprocessable Entity error was occurring when using application/x-www-form-urlencoded content type.
To address this, I made a small change to support form-based input without modifying Airflow’s core structure or authentication logic.
The goal was to make the authentication endpoint more user-friendly, especially for those exploring the API via tools like Swagger.

While working on this, I also observed that JWT token handling in Airflow is not yet fully unified across different parts of the system.
I believe this presents an opportunity to submit a follow-up PR that would refactor and unify the token handling logic,
ensuring consistency and paving the way for smoother integration of OAuth2.0 and SSO in the future.

(Note: I drafted my thoughts and structure in Korean first, based on my understanding of the feedback and the current state of the codebase.
ChatGPT helped only with polishing the English writing and markdown formatting — all technical reasoning and intent came from my own review.)

If there's anything I may have misunderstood, I’d really appreciate your clarification.

@ashb

kyungjunleeme · 2025-07-23T06:12:26Z

I'll take some time to read through the AIPs more thoroughly and will reach out again when I'm ready to request a review.
In the meantime, if you have a chance, I’d greatly appreciate it if you could leave your thoughts on the points I mentioned above — your feedback would really help broaden my thinking.

cf)

airflow-core/src/airflow/api_fastapi/auth/managers/simple/utils.py

airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/openapi-gen/queries/queries.ts

...e/src/airflow/api_fastapi/auth/managers/simple/openapi/v2-simple-auth-manager-generated.yaml

jason810496

Cool! LGTM.

bugraoz93

Looks good! Thanks @kyungjunleeme ! Small suggestion to speed up the procedures, please resolve any thread you think you addressed. This can make merging a lot easier since not everyone checking the PR has the full context of all of the threads :)

kyungjunleeme · 2025-07-30T15:30:16Z

@bugraoz93 Thank you, I followed your instructions

jason810496 · 2025-08-01T07:12:29Z

It seems that this PR still needs @ashb's approval before it can be merged.
(Due to GitHub restrictions, if any reviewer has requested changes, the PR requires that specific person's approval to unblock and proceed with the merge.)

Update: I can dismissed review from ash

kyungjunleeme · 2025-08-01T07:49:27Z

Ah ha thank you for telling me! :)

Resolved.

* ADD: test code for application/x-www-form-urlencoded * ADD: FORM * ADD: header_content_type_json_or_form_depends * NEW: parse_login_body * CHG: create_token * DEL: parametrize

kyungjunleeme requested a review from vincbeck as a code owner July 21, 2025 15:24

boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jul 21, 2025

vincbeck reviewed Jul 21, 2025

View reviewed changes

kyungjunleeme changed the title ~~Change logic in auth with swagger uI~~ Change logic in auth with swagger ui Jul 21, 2025

kyungjunleeme force-pushed the feature/temp-fix-422 branch from 5e27f9d to 8bb8ae6 Compare July 21, 2025 22:30

kyungjunleeme marked this pull request as draft July 22, 2025 02:04

kyungjunleeme marked this pull request as ready for review July 22, 2025 03:31

kyungjunleeme force-pushed the feature/temp-fix-422 branch from ebd3ec8 to 25becb1 Compare July 22, 2025 03:32

kyungjunleeme marked this pull request as draft July 22, 2025 05:31

kyungjunleeme force-pushed the feature/temp-fix-422 branch from 592c206 to 3ff212c Compare July 22, 2025 06:40

kyungjunleeme marked this pull request as ready for review July 22, 2025 06:40

kyungjunleeme requested review from bugraoz93, kaxil and potiuk as code owners July 22, 2025 06:40

kyungjunleeme mentioned this pull request Jul 22, 2025

FIX - pre-commit scope (generate-airflowctl-datamodels) #53624

Merged

kyungjunleeme force-pushed the feature/temp-fix-422 branch from 203c429 to c332acd Compare July 22, 2025 12:23

kyungjunleeme mentioned this pull request Jul 22, 2025

Change pre-commit propety(v1) #53636

Merged

kyungjunleeme requested review from ashb, gopidesupavan and jason810496 as code owners July 22, 2025 14:20

kyungjunleeme force-pushed the feature/temp-fix-422 branch from e83720b to 28c888f Compare July 22, 2025 14:20

ashb previously requested changes Jul 22, 2025

View reviewed changes

airflow-core/src/airflow/api_fastapi/auth/managers/simple/routes/login.py Outdated Show resolved Hide resolved

kyungjunleeme marked this pull request as draft July 22, 2025 15:38

kyungjunleeme force-pushed the feature/temp-fix-422 branch from 619e146 to 49e42c2 Compare July 23, 2025 00:11

kyungjunleeme marked this pull request as ready for review July 23, 2025 02:30

kyungjunleeme force-pushed the feature/temp-fix-422 branch from d98afb8 to 2ce8683 Compare July 23, 2025 04:29

kyungjunleeme marked this pull request as draft July 23, 2025 05:48

jason810496 reviewed Jul 25, 2025

View reviewed changes

airflow-core/src/airflow/api_fastapi/auth/managers/simple/utils.py Outdated Show resolved Hide resolved

airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/openapi-gen/queries/queries.ts Outdated Show resolved Hide resolved

kyungjunleeme force-pushed the feature/temp-fix-422 branch from 50e0419 to 280de53 Compare July 26, 2025 07:51

kyungjunleeme requested review from ephraimbuddy, pierrejeambrun, rawwar and shubhamraj-git as code owners July 26, 2025 07:51

kyungjunleeme force-pushed the feature/temp-fix-422 branch from 280de53 to 9f78fc3 Compare July 26, 2025 08:03

kyungjunleeme commented Jul 26, 2025

View reviewed changes

...e/src/airflow/api_fastapi/auth/managers/simple/openapi/v2-simple-auth-manager-generated.yaml Show resolved Hide resolved

kyungjunleeme added 5 commits July 26, 2025 18:58

ADD: test code for application/x-www-form-urlencoded

955c74b

ADD: FORM

f9c6777

ADD: header_content_type_json_or_form_depends

41fedd0

NEW: parse_login_body

c53e721

CHG: create_token

d662892

kyungjunleeme force-pushed the feature/temp-fix-422 branch from 9f78fc3 to d662892 Compare July 26, 2025 09:58

kyungjunleeme requested a review from jason810496 July 26, 2025 10:50

kyungjunleeme added 2 commits July 27, 2025 18:41

Merge branch 'main' into feature/temp-fix-422

0254daa

DEL: parametrize

11faa6b

jason810496 approved these changes Jul 28, 2025

View reviewed changes

vincbeck approved these changes Jul 30, 2025

View reviewed changes

bugraoz93 approved these changes Jul 30, 2025

View reviewed changes

kyungjunleeme requested review from bugraoz93, jason810496 and vincbeck August 1, 2025 01:19

jason810496 merged commit ff36fb5 into apache:main Aug 1, 2025
103 checks passed

Change logic in auth with swagger ui #53597

Change logic in auth with swagger ui #53597

Uh oh!

Conversation

kyungjunleeme commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Descritpion

Result

Uh oh!

vincbeck left a comment

Choose a reason for hiding this comment

Uh oh!

kyungjunleeme commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kyungjunleeme commented Jul 22, 2025

Reflections on the Feedback and Purpose of the PR

Uh oh!

kyungjunleeme commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

bugraoz93 left a comment

Choose a reason for hiding this comment

Uh oh!

kyungjunleeme commented Jul 30, 2025

Uh oh!

jason810496 commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kyungjunleeme commented Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kyungjunleeme commented Jul 21, 2025 •

edited

Loading

kyungjunleeme commented Jul 22, 2025 •

edited

Loading

kyungjunleeme commented Jul 23, 2025 •

edited

Loading

jason810496 commented Aug 1, 2025 •

edited

Loading