-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Change pre-commit propety(v1) #53636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What problem does it solve really ? |
|
I realized that while I updated the API, I missed the corresponding frontend changes. Unfortunately, I wasn't able to reproduce the issue on my side, but I should have been more careful before submitting the PR. I sincerely apologize for the oversight. I’ll make the necessary adjustments and prepare an updated version for review soon. I also want to acknowledge that I didn’t fully consider how valuable your time as a reviewer is—I'm truly sorry for that. |
No worries - I was just wondering what's wrong there :) |
The current so it doesn't catch changes like to ensure all OpenAPI changes under the There is an issue with the pre-commit scope, which is causing the following failure: https://github.com/apache/airflow/actions/runs/16489362751/job/46620971120 |
b5890a3 to
69a1daf
Compare
69a1daf to
7712f5c
Compare
7712f5c to
5774ab6
Compare
|
Cool |
|
Now it makes sense :) |
(cherry picked from commit 9d9924e) Co-authored-by: Kyungjun Lee <kyungjunlee.me@gmail.com>
it solve ci error in github.
related #53597
It cause error. refer to below image.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.