Skip to content

Conversation

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jul 24, 2025

Second big chunk for #52141

Now MappedOperator in core is entirely detached from the SDK.

I decided to remove the start_from_trigger code entirely from MappedOperator (the code path is already entirely unreachable in Airflow 3, see referenced snippet below) since it causes too many Mypy errors.

if not self.partial_kwargs.get("start_from_trigger", self.start_from_trigger):
log.warning(
"Starting a mapped task from triggerer is currently unsupported",
task_id=self.task_id,
dag_id=self.dag_id,
)
return False

We can always get the implementation back from Git history when we re-implement the feature with the new task runner.

@uranusjr uranusjr force-pushed the remove-mappedoperator-from-core branch 11 times, most recently from c734708 to 689de4c Compare July 25, 2025 10:41
@uranusjr uranusjr marked this pull request as ready for review July 25, 2025 19:25
@uranusjr
Copy link
Member Author

uranusjr commented Jul 25, 2025

I believe the Mypy failure is unrelated; fixing in #53772. Fixed

@uranusjr uranusjr force-pushed the remove-mappedoperator-from-core branch from 689de4c to a2a42f2 Compare July 26, 2025 03:06
@Lee-W Lee-W self-requested a review July 28, 2025 09:38
@uranusjr uranusjr self-assigned this Aug 4, 2025
@uranusjr uranusjr force-pushed the remove-mappedoperator-from-core branch 6 times, most recently from 3fe0af4 to d267a11 Compare August 13, 2025 13:38
@uranusjr uranusjr force-pushed the remove-mappedoperator-from-core branch from d267a11 to bbebd5d Compare August 13, 2025 22:55
Now MappedOperator in core is entirely detached from the SDK.

I decided to remove the start_from_trigger code entirely (the code path
is already entirely unreachable in Airflow 3) since it causes too many
Mypy errors. We can always get the implementation back from Git history
when we re-implement the feature with the new task runner.
@uranusjr uranusjr force-pushed the remove-mappedoperator-from-core branch from bbebd5d to 3b57505 Compare August 13, 2025 23:13
@uranusjr uranusjr merged commit cbfa578 into apache:main Aug 14, 2025
105 checks passed
@uranusjr uranusjr deleted the remove-mappedoperator-from-core branch August 14, 2025 06:48
@amoghrajesh amoghrajesh mentioned this pull request Aug 26, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants