-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove MappedOperator inheritance #53696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
uranusjr
merged 1 commit into
apache:main
from
astronomer:remove-mappedoperator-from-core
Aug 14, 2025
Merged
Remove MappedOperator inheritance #53696
uranusjr
merged 1 commit into
apache:main
from
astronomer:remove-mappedoperator-from-core
Aug 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c734708 to
689de4c
Compare
Member
Author
|
|
689de4c to
a2a42f2
Compare
Lee-W
reviewed
Jul 29, 2025
kaxil
approved these changes
Aug 11, 2025
3fe0af4 to
d267a11
Compare
d267a11 to
bbebd5d
Compare
Now MappedOperator in core is entirely detached from the SDK. I decided to remove the start_from_trigger code entirely (the code path is already entirely unreachable in Airflow 3) since it causes too many Mypy errors. We can always get the implementation back from Git history when we re-implement the feature with the new task runner.
bbebd5d to
3b57505
Compare
2 tasks
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second big chunk for #52141
Now MappedOperator in core is entirely detached from the SDK.
I decided to remove the start_from_trigger code entirely from MappedOperator (the code path is already entirely unreachable in Airflow 3, see referenced snippet below) since it causes too many Mypy errors.
airflow/airflow-core/src/airflow/models/mappedoperator.py
Lines 75 to 81 in 0c17884
We can always get the implementation back from Git history when we re-implement the feature with the new task runner.