Fix Graph View for DAGs with mapped operators #54756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
reviewed
Aug 21, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Can you also add a pytest to prevent regression of this error?
Contributor
Author
|
Yes for sure, I'll add a unit test early tomorrow |
Member
|
cc: @kaxil -> I think that one would be great to get in 3.0.6 |
Member
There was a problem hiding this comment.
Nice, yes a regression test would be nice. Don't know how and when this got broken. Most probably #53696
Member
Verified, v3-0-test branch is not affect, must be a change targeted for 3.1.0 that broke it. But we can still preventive cherry pick. |
isaiahiruoha
force-pushed
the
iiruoha/fix-missing-graph-view-with-mapped-operators
branch
from
854de19 to
db3a478
Compare
Contributor
|
This should close #54665 too. Thanks. |
2 tasks
o-nikolas
approved these changes
Aug 22, 2025
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
Nice, love it when there are more lines of test code added then src code 😁
o-nikolas
deleted the
iiruoha/fix-missing-graph-view-with-mapped-operators
branch
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 22, 2025
This reverts commit e790409.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 23, 2025
…organize tests Follow-up of the fix in apache#54756 - Move `task_group_to_dict` and `task_group_to_dict_grid` functions from `task-sdk` to `airflow-core` API services - Update import paths in `grid.py` and `structure.py` to use new server-side location - Update deprecation mappings to point to new FastAPI service module locations - Remove `AbstractOperator` from isinstance checks in server-side functions (now handles only serialized objects) - Split mixed tests: moved TaskGroup functionality tests to `task-sdk`, keep server function tests in `airflow-core` - Add comprehensive TaskGroup tests in `task-sdk` covering creation, relationships, decorators, and validation - Create clear architectural boundary: client-side TaskGroup authoring vs server-side serialized DAG processing
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 23, 2025
…organize tests Follow-up of the fix in apache#54756 - Move `task_group_to_dict` and `task_group_to_dict_grid` functions from `task-sdk` to `airflow-core` API services - Update import paths in `grid.py` and `structure.py` to use new server-side location - Update deprecation mappings to point to new FastAPI service module locations - Remove `AbstractOperator` from isinstance checks in server-side functions (now handles only serialized objects) - Split mixed tests: moved TaskGroup functionality tests to `task-sdk`, keep server function tests in `airflow-core` - Add comprehensive TaskGroup tests in `task-sdk` covering creation, relationships, decorators, and validation - Create clear architectural boundary: client-side TaskGroup authoring vs server-side serialized DAG processing
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 26, 2025
…organize tests Follow-up of the fix in apache#54756 - Move `task_group_to_dict` and `task_group_to_dict_grid` functions from `task-sdk` to `airflow-core` API services - Update import paths in `grid.py` and `structure.py` to use new server-side location - Update deprecation mappings to point to new FastAPI service module locations - Remove `AbstractOperator` from isinstance checks in server-side functions (now handles only serialized objects) - Split mixed tests: moved TaskGroup functionality tests to `task-sdk`, keep server function tests in `airflow-core` - Add comprehensive TaskGroup tests in `task-sdk` covering creation, relationships, decorators, and validation - Create clear architectural boundary: client-side TaskGroup authoring vs server-side serialized DAG processing
kaxil
added a commit
that referenced
this pull request
Aug 26, 2025
…organize tests (#54857) Follow-up of the fix in #54756 - Move `task_group_to_dict` and `task_group_to_dict_grid` functions from `task-sdk` to `airflow-core` API services - Update import paths in `grid.py` and `structure.py` to use new server-side location - Update deprecation mappings to point to new FastAPI service module locations - Remove `AbstractOperator` from isinstance checks in server-side functions (now handles only serialized objects) - Split mixed tests: moved TaskGroup functionality tests to `task-sdk`, keep server function tests in `airflow-core` - Add comprehensive TaskGroup tests in `task-sdk` covering creation, relationships, decorators, and validation - Create clear architectural boundary: client-side TaskGroup authoring vs server-side serialized DAG processing
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
* Add unit tests to prevent regression
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…organize tests (apache#54857) Follow-up of the fix in apache#54756 - Move `task_group_to_dict` and `task_group_to_dict_grid` functions from `task-sdk` to `airflow-core` API services - Update import paths in `grid.py` and `structure.py` to use new server-side location - Update deprecation mappings to point to new FastAPI service module locations - Remove `AbstractOperator` from isinstance checks in server-side functions (now handles only serialized objects) - Split mixed tests: moved TaskGroup functionality tests to `task-sdk`, keep server function tests in `airflow-core` - Add comprehensive TaskGroup tests in `task-sdk` covering creation, relationships, decorators, and validation - Create clear architectural boundary: client-side TaskGroup authoring vs server-side serialized DAG processing
nothingmin
pushed a commit
to nothingmin/airflow
that referenced
this pull request
Sep 2, 2025
…organize tests (apache#54857) Follow-up of the fix in apache#54756 - Move `task_group_to_dict` and `task_group_to_dict_grid` functions from `task-sdk` to `airflow-core` API services - Update import paths in `grid.py` and `structure.py` to use new server-side location - Update deprecation mappings to point to new FastAPI service module locations - Remove `AbstractOperator` from isinstance checks in server-side functions (now handles only serialized objects) - Split mixed tests: moved TaskGroup functionality tests to `task-sdk`, keep server function tests in `airflow-core` - Add comprehensive TaskGroup tests in `task-sdk` covering creation, relationships, decorators, and validation - Create clear architectural boundary: client-side TaskGroup authoring vs server-side serialized DAG processing
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 24, 2025
…organize tests (#54857) Follow-up of the fix in apache/airflow#54756 - Move `task_group_to_dict` and `task_group_to_dict_grid` functions from `task-sdk` to `airflow-core` API services - Update import paths in `grid.py` and `structure.py` to use new server-side location - Update deprecation mappings to point to new FastAPI service module locations - Remove `AbstractOperator` from isinstance checks in server-side functions (now handles only serialized objects) - Split mixed tests: moved TaskGroup functionality tests to `task-sdk`, keep server function tests in `airflow-core` - Add comprehensive TaskGroup tests in `task-sdk` covering creation, relationships, decorators, and validation - Create clear architectural boundary: client-side TaskGroup authoring vs server-side serialized DAG processing GitOrigin-RevId: c8a0f51f89dc5c75b86c6888154073c08c2a0671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #54753
closes #54665
Problem Description
The Airflow UI Graph View fails to display DAGs containing dynamically mapped operators (created with
.expand()). When users try to view such DAGs in the Graph View, the page fails to load and shows a 500 Internal Server Error due to cascading errors in the UI rendering pipeline.Errors Observed
First Error:
Subsequent Error (after fixing the first):
Both errors occur because
MappedOperatorinstances are incorrectly treated asTaskGroupobjects throughout the UI rendering pipeline, causing the system to call TaskGroup-specific methods that don't exist onMappedOperator.Proposed Solution
Updated both functions to properly recognize
MappedOperatoras a task-like object rather than a TaskGroup. These changes ensureMappedOperatorinstances are handled consistently as tasks throughout the entire UI rendering pipeline, preventing both the initial error and subsequent cascading failures.Testing
task.expand()operations^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.