-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove unnecessary group_by clause in event logs query #53733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce the linked issue locally, but that group_by sure look suspicious, any specific setup to be able to reproduce the 500 error ? I tried on mysql, postgres and sqllite, without succeeding.
The group_by(Log.id) clause was redundant since Log.id is the primary key and doesn't affect the query results. This simplifies the query without changing functionality. Fixes apache#53695
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the PR and LGTM.
It would be nice to providing the reproduce step for the error.
|
Yeah. Unit tests would be great. |
|
If you want to reproduce this error in PostgreSQL, you'll need to use a version older than 9.1, since PostgreSQL 9.1 and later versions allow non-aggregated columns in SELECT if they are functionally dependent on the GROUP BY columns. https://www.postgresql.org/message-id/20100807024409.35E3A7541D7@cvs.postgresql.org |
|
I removed the |
|
That should be removed indeed, also the reported of the issues mentioned that he was using postgres 15.12. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…53733) The group_by(Log.id) clause was redundant since Log.id is the primary key and doesn't affect the query results. This simplifies the query without changing functionality. Fixes #53695 (cherry picked from commit 85d80cd) Co-authored-by: xiaohuanlin <33860497+xiaohuanlin@users.noreply.github.com>
…pache#53733) The group_by(Log.id) clause was redundant since Log.id is the primary key and doesn't affect the query results. This simplifies the query without changing functionality. Fixes apache#53695 (cherry picked from commit 85d80cd) Co-authored-by: xiaohuanlin <33860497+xiaohuanlin@users.noreply.github.com>
…53733) (#53807) The group_by(Log.id) clause was redundant since Log.id is the primary key and doesn't affect the query results. This simplifies the query without changing functionality. Fixes #53695 (cherry picked from commit 85d80cd) Co-authored-by: xiaohuanlin <33860497+xiaohuanlin@users.noreply.github.com>
The group_by(Log.id) clause was redundant since Log.id is the primary key and doesn't affect the query results. This simplifies the query without changing functionality. Fixes apache#53695
The group_by(Log.id) clause was redundant since Log.id is the primary key and doesn't affect the query results. This simplifies the query without changing functionality. Fixes apache#53695

The group_by(Log.id) clause was redundant since Log.id is the primary key and doesn't affect the query results. This simplifies the query without changing functionality.
Fixes #53695
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.