[v3-0-test] Remove unnecessary group_by clause in event logs query (#53733) #53807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…53733) The group_by(Log.id) clause was redundant since Log.id is the primary key and doesn't affect the query results. This simplifies the query without changing functionality. Fixes #53695 (cherry picked from commit 85d80cd) Co-authored-by: xiaohuanlin <33860497+xiaohuanlin@users.noreply.github.com>
pierrejeambrun
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
jason810496
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group_by(Log.id) clause was redundant since Log.id is the primary key
and doesn't affect the query results. This simplifies the query without
changing functionality.
Fixes #53695
(cherry picked from commit 85d80cd)
Co-authored-by: xiaohuanlin 33860497+xiaohuanlin@users.noreply.github.com