Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 26, 2025

While we want to follow automated upgrades of dependencies and constraints on vX-Y-test branches, in order to pull latest providers from PyPI, this might have some undesired effects - for example some provider's dependencies might break tests from importing or produce false tests results if such tests depend on - for example - importing all provider example dags. This happens for example for serialization tests - which import all example dags to test that serialization works for them.

Such tests should be simply skipped when target branch is different than main.

This PR adds "skip_if_not_on_main" marker and uses it for two tests that are currently failing on v3-0-test branch due to weaviate dependency upgrades causing import error and some undesired warnings.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

While we want to follow automated upgrades of dependencies and constraints
on vX-Y-test branches, in order to pull latest providers from PyPI,
this might have some undesired effects - for example some provider's
dependencies might break tests from importing or produce false
tests results if such tests depend on - for example - importing all
provider example dags. This happens for example for serialization
tests - which import all example dags to test that serialization
works for them.

Such tests should be simply skipped when target branch is different
than main.

This PR adds "skip_if_not_on_main" marker and uses it for two tests
that are currently failing on v3-0-test branch due to weaviate
dependency upgrades causing import error and some undesired warnings.
@boring-cyborg boring-cyborg bot added area:dev-tools area:serialization backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 26, 2025
@potiuk potiuk merged commit 92909e5 into apache:main Jul 26, 2025
106 checks passed
@potiuk potiuk deleted the skip-some-tests-on-non-main-branch branch July 26, 2025 07:47
@github-actions
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 92909e5 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk added a commit to potiuk/airflow that referenced this pull request Jul 26, 2025
…hanges (apache#53776)

While we want to follow automated upgrades of dependencies and constraints
on vX-Y-test branches, in order to pull latest providers from PyPI,
this might have some undesired effects - for example some provider's
dependencies might break tests from importing or produce false
tests results if such tests depend on - for example - importing all
provider example dags. This happens for example for serialization
tests - which import all example dags to test that serialization
works for them.

Such tests should be simply skipped when target branch is different
than main.

This PR adds "skip_if_not_on_main" marker and uses it for two tests
that are currently failing on v3-0-test branch due to weaviate
dependency upgrades causing import error and some undesired warnings.
(cherry picked from commit 92909e5)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit that referenced this pull request Jul 26, 2025
…hanges (#53776) (#53777)

While we want to follow automated upgrades of dependencies and constraints
on vX-Y-test branches, in order to pull latest providers from PyPI,
this might have some undesired effects - for example some provider's
dependencies might break tests from importing or produce false
tests results if such tests depend on - for example - importing all
provider example dags. This happens for example for serialization
tests - which import all example dags to test that serialization
works for them.

Such tests should be simply skipped when target branch is different
than main.

This PR adds "skip_if_not_on_main" marker and uses it for two tests
that are currently failing on v3-0-test branch due to weaviate
dependency upgrades causing import error and some undesired warnings.
(cherry picked from commit 92909e5)
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
…he#53776)

While we want to follow automated upgrades of dependencies and constraints
on vX-Y-test branches, in order to pull latest providers from PyPI,
this might have some undesired effects - for example some provider's
dependencies might break tests from importing or produce false
tests results if such tests depend on - for example - importing all
provider example dags. This happens for example for serialization
tests - which import all example dags to test that serialization
works for them.

Such tests should be simply skipped when target branch is different
than main.

This PR adds "skip_if_not_on_main" marker and uses it for two tests
that are currently failing on v3-0-test branch due to weaviate
dependency upgrades causing import error and some undesired warnings.
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
…he#53776)

While we want to follow automated upgrades of dependencies and constraints
on vX-Y-test branches, in order to pull latest providers from PyPI,
this might have some undesired effects - for example some provider's
dependencies might break tests from importing or produce false
tests results if such tests depend on - for example - importing all
provider example dags. This happens for example for serialization
tests - which import all example dags to test that serialization
works for them.

Such tests should be simply skipped when target branch is different
than main.

This PR adds "skip_if_not_on_main" marker and uses it for two tests
that are currently failing on v3-0-test branch due to weaviate
dependency upgrades causing import error and some undesired warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:serialization backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants