[v3-0-test] Make branch tests more resilient to provider dependency c… #53777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges (apache#53776) While we want to follow automated upgrades of dependencies and constraints on vX-Y-test branches, in order to pull latest providers from PyPI, this might have some undesired effects - for example some provider's dependencies might break tests from importing or produce false tests results if such tests depend on - for example - importing all provider example dags. This happens for example for serialization tests - which import all example dags to test that serialization works for them. Such tests should be simply skipped when target branch is different than main. This PR adds "skip_if_not_on_main" marker and uses it for two tests that are currently failing on v3-0-test branch due to weaviate dependency upgrades causing import error and some undesired warnings. (cherry picked from commit 92909e5) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
boring-cyborg
bot
added
area:dev-tools
area:serialization
backport-to-v3-1-test
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hanges (#53776)
While we want to follow automated upgrades of dependencies and constraints on vX-Y-test branches, in order to pull latest providers from PyPI, this might have some undesired effects - for example some provider's dependencies might break tests from importing or produce false tests results if such tests depend on - for example - importing all provider example dags. This happens for example for serialization tests - which import all example dags to test that serialization works for them.
Such tests should be simply skipped when target branch is different than main.
This PR adds "skip_if_not_on_main" marker and uses it for two tests that are currently failing on v3-0-test branch due to weaviate dependency upgrades causing import error and some undesired warnings. (cherry picked from commit 92909e5)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.