AIP-86 - Add async support for Notifiers #53831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramitkataria
requested review from
amoghrajesh,
ashb,
eladkal and
kaxil
as code owners
Contributor
Author
|
Unit tests |
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
14bdf25 to
5720afa
Compare
Member
|
This needs some documentation. |
Contributor
|
Looks good so far, pending docs and unit tests. |
o-nikolas
reviewed
Jul 29, 2025
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
I wonder if @ashb or @amoghrajesh want to have a look at the TaskSDK pieces here.
This makes the `BaseNotifier` awaitable and implements the necessary changes required for the notifiers to work in non-blocking mode (required for DeadlineAlerts). Since notifiers use hooks which may need to use the TaskSDK API if they will fetching a `Connection`, I've added async counterparts to relevant TaskSDK functions as well, while avoiding as much code duplication as I could. I've included changes needed to `SlackWebhookNotifier` as an example and will add support for some other common ones soon.
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
b386f55 to
3c94260
Compare
ashb
reviewed
Aug 2, 2025
ashb
reviewed
Aug 2, 2025
ashb
reviewed
Aug 2, 2025
ashb
reviewed
Aug 2, 2025
amoghrajesh
reviewed
Aug 4, 2025
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
d081ff0 to
ed9bbec
Compare
ferruzzi
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
a048aed to
1c76f75
Compare
Contributor
|
I feel like it would be inappropriate for me to merge since I wrote some of the code, so I'm going to wait on at least someone else to approve it. |
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
df8c7ca to
bd5f89f
Compare
ashb
reviewed
Aug 18, 2025
airflow-core/docs/administration-and-deployment/logging-monitoring/callbacks.rst
Outdated
Show resolved
Hide resolved
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
27d3767 to
65e3655
Compare
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
c3187fd to
ad5caac
Compare
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
ad5caac to
7c27539
Compare
o-nikolas
approved these changes
Aug 25, 2025
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
There is a lot to review here, but it seems reasonable 👍
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
c9ad460 to
1c69759
Compare
ramitkataria
force-pushed
the
ramitkataria/deadlines/async-notifiers
branch
from
353a245 to
b88859c
Compare
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
This makes the `BaseNotifier` awaitable and implements the necessary changes required for the notifiers to work in non-blocking mode (required for DeadlineAlerts). Since notifiers use hooks which may need to use the TaskSDK API if they will fetching a `Connection`, I've added async counterparts to relevant TaskSDK functions as well, while avoiding as much code duplication as I could. Includes changes needed to `SlackWebhookNotifier` as an example. --------- Co-authored-by: ferruzzi <ferruzzi@amazon.com>
nothingmin
pushed a commit
to nothingmin/airflow
that referenced
this pull request
Sep 2, 2025
This makes the `BaseNotifier` awaitable and implements the necessary changes required for the notifiers to work in non-blocking mode (required for DeadlineAlerts). Since notifiers use hooks which may need to use the TaskSDK API if they will fetching a `Connection`, I've added async counterparts to relevant TaskSDK functions as well, while avoiding as much code duplication as I could. Includes changes needed to `SlackWebhookNotifier` as an example. --------- Co-authored-by: ferruzzi <ferruzzi@amazon.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
BaseNotifierawaitable and implements the necessary changes required for the notifiers to work in non-blocking mode (required for DeadlineAlerts). Since notifiers use hooks which may need to use the TaskSDK API if they will fetching aConnection, I've added async counterparts to relevant TaskSDK functions as well, while avoiding as much code duplication as I could.I've included changes needed to
SlackWebhookNotifieras an example and will add support for some other common ones soon.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.