-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add Async support for SMTP Notifier #55308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fdae313 to
53da449
Compare
2c6d026 to
5ba509b
Compare
5ba509b to
aee9962
Compare
ramitkataria
reviewed
Sep 9, 2025
providers/slack/src/airflow/providers/slack/notifications/slack_webhook.py
Show resolved
Hide resolved
ramitkataria
approved these changes
Sep 9, 2025
Contributor
ramitkataria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of templating-related suggestions and some nits but otherwise looks good to me!
providers/smtp/src/airflow/providers/smtp/notifications/smtp.py
Outdated
Show resolved
Hide resolved
providers/smtp/src/airflow/providers/smtp/notifications/smtp.py
Outdated
Show resolved
Hide resolved
providers/smtp/src/airflow/providers/smtp/notifications/smtp.py
Outdated
Show resolved
Hide resolved
providers/slack/src/airflow/providers/slack/notifications/slack_webhook.py
Show resolved
Hide resolved
o-nikolas
reviewed
Sep 10, 2025
providers/slack/src/airflow/providers/slack/notifications/slack_webhook.py
Outdated
Show resolved
Hide resolved
o-nikolas
approved these changes
Sep 12, 2025
potiuk
approved these changes
Sep 12, 2025
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
Brunda10
pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
78 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #53831 and part of #55237
Dags used for manual testing are below.
email_operatoris a "control" to make sure the SMPT connection is working as expected,email_as_success_callbackconfirms that existing synchronous notifier is still working, andemail_as_success_callbacktests the new async functionality^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.