Fix import for SMTP provider #56053
Merged
Fix import for SMTP provider #56053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
kaxil
referenced
this pull request
Sep 24, 2025
* Add Async support for SMTP Notifier * Fix tests and remove context form async support for now * overengineer the tests to remove magic strings * fix imports * fix imports and some small style changes * Add backcompat checks * static checks * fix imports * PR fixes * static fixes
vatsrahul1001
approved these changes
Sep 24, 2025
eladkal
approved these changes
Sep 24, 2025
Member
|
cc @eladkal -- we'll want to include this in the wave you're about to cut too. (Ah you approved it while I was writing this comment. Go figure) |
hussein-awala
approved these changes
Sep 24, 2025
19 tasks
kaxil
added a commit
that referenced
this pull request
Sep 25, 2025
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was using one for tests! I'll add a Pre-commit / prek separetely but this is fine for now.
This was added in #55308
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.