-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Update color palette and leverage Chakra semantic tokens #53981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
airflow-core/src/airflow/ui/src/theme/react_components_analysis.md
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/src/login/Login.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/src/main.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. We just need a rebase and then I left a few comments on the auth page and the new markdown file
|
@odaneau-astro I'm hoping we can get this in time for 3.1 |
c506455 to
4be4c6f
Compare
95143d2 to
9462138
Compare
|
I think a lot of the static checks can be fixed simply by running |
978c074 to
f387f0e
Compare
|
#protm |
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658 (cherry picked from commit 1046874)
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
✅ Changes made: - Introduce semantic tokens for colors used across all components. This allows for user customization in the future (see apache#53443). - Added the Tailwind V4 color tokens to theme.ts in place of the default Chakra UI colors. This color palette offers better accessibility across both dark and light modes. - Updated the existing semantic tokens to use the newly added Tailwind color tokens instead of default Chakra colors. - Replaced all references to color Tokens with Semantic tokens to allow changing colors later without having to change the components. closes: apache#49658
Newer PR for #49658
✅ Changes made:
📷 Preview:








Light Mode
Dark Mode
closes: #49658