UI fixes for calendar #55476
Merged
UI fixes for calendar #55476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
RoyLee1224
requested review from
Lee-W,
bbovenzi,
jason810496,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
|
I am fine with either green or blue. No strong preference. It's common that charts and graphs will have their own color scheme separate from the rest of the app they're inside of. |
bbovenzi
reviewed
Sep 12, 2025
bbovenzi
reviewed
Sep 12, 2025
airflow-core/src/airflow/ui/src/pages/Dag/Calendar/Calendar.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
reviewed
Sep 12, 2025
Contributor
Author
Update
|
RoyLee1224
force-pushed
the
calendar-ui-fix
branch
from
dd3d4a8 to
adecb72
Compare
bbovenzi
approved these changes
Sep 17, 2025
kaxil
pushed a commit
that referenced
this pull request
Sep 18, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support (cherry picked from commit c76e3dd)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* fix: modify calendar UI for non-selected year cells * style: UI design roll back * feat(ui): enhance calendar tooltip with rich content and filter support * fix(i18n): Revert new translation key to use fallback * style: use semantic values for colors * feat(ui): implement Portal-based calendar tooltips with theme support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues & PR
closes: #55484
related:#53981
TO-DO
!isInSelectedYearplannedcellsnoRunstranslation issueScreenshots
calendar_new.mp4
P.S. the
mock databutton is just for demo purpose, not part of the actual UIDiscussion
This is open for discussion, but my preference is green for 'total runs'. I acknowledge the potential overlap with 'success', but green conveys a positive, high-activity signal that aligns well with the concept of total runs.
IMO, blue is used for the 'running' status.
Open to other color suggestions if the team has different ideas!
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.