Skip running db queries for Spans when they are disabled #54075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
Shlomit-B
force-pushed
the
bug/53405-skip-span-queries-when-disabled
branch
from
cf25f1f to
0c85107
Compare
Member
|
@xBis7 Looks okay to me -- are you able to take a quick look too? |
xBis7
reviewed
Aug 5, 2025
ashb
changed the title
ashb
approved these changes
Aug 6, 2025
ashb
added
the
backport-to-v3-1-test
ashb
force-pushed
the
bug/53405-skip-span-queries-when-disabled
branch
from
0c85107 to
c44a4de
Compare
ashb
force-pushed
the
bug/53405-skip-span-queries-when-disabled
branch
from
c44a4de to
83927ce
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
…54075) Skips recording span and metrics in the scheduler when tracing or metrics are disabled. This avoids unnecessary function calls and improves efficiency. Changes Made: - Added functions to check config values - Used these helpers to avoid computing span and pool metrics in _run_scheduler_loop when not needed (cherry picked from commit 67f5565) Co-authored-by: Shlomit-B <76184325+Shlomit-B@users.noreply.github.com> closes: #53405
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 12, 2025
…pache#54075) Skips recording span and metrics in the scheduler when tracing or metrics are disabled. This avoids unnecessary function calls and improves efficiency. Changes Made: - Added functions to check config values - Used these helpers to avoid computing span and pool metrics in _run_scheduler_loop when not needed (cherry picked from commit 67f5565) Co-authored-by: Shlomit-B <76184325+Shlomit-B@users.noreply.github.com> closes: apache#53405
github-actions bot
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 12, 2025
…pache#54075) Skips recording span and metrics in the scheduler when tracing or metrics are disabled. This avoids unnecessary function calls and improves efficiency. Changes Made: - Added functions to check config values - Used these helpers to avoid computing span and pool metrics in _run_scheduler_loop when not needed (cherry picked from commit 67f5565) Co-authored-by: Shlomit-B <76184325+Shlomit-B@users.noreply.github.com> closes: apache#53405
ashb
pushed a commit
that referenced
this pull request
Aug 12, 2025
…54075) (#54404) Skips recording span and metrics in the scheduler when tracing or metrics are disabled. This avoids unnecessary function calls and improves efficiency. Changes Made: - Added functions to check config values - Used these helpers to avoid computing span and pool metrics in _run_scheduler_loop when not needed (cherry picked from commit 67f5565) Co-authored-by: Shlomit-B <76184325+Shlomit-B@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips recording span and metrics in the scheduler when tracing or metrics are disabled. This avoids unnecessary function calls and improves efficiency.
Changes Made:
closes: #53405
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.