Skip to content

Conversation

@Shlomit-B
Copy link
Contributor

@Shlomit-B Shlomit-B commented Aug 17, 2025

This PR is a follow-up to previous optimization (#54075).
I discovered two additional functions that continue to execute when tracing is disabled, causing unnecessary overhead.
related: #53405

cc @kaxil - found during RC 3.0.5rc1 testing


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Aug 17, 2025
@Shlomit-B Shlomit-B marked this pull request as ready for review August 17, 2025 21:30
@Shlomit-B Shlomit-B requested review from XD-DENG and ashb as code owners August 17, 2025 21:30
@ashb ashb changed the title Bug/53405 skip span queries when disabled followup Skip more span queries when tracing is disabled Aug 18, 2025
@ashb ashb changed the title Skip more span queries when tracing is disabled Skip more span-related DB queries in the scheduler when tracing is disabled Aug 18, 2025
@ashb ashb added this to the Airflow 3.0.6 milestone Aug 18, 2025
@ashb ashb added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Aug 18, 2025
@ashb ashb merged commit 4550cd2 into apache:main Aug 18, 2025
108 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 18, 2025
…racing is disabled (#54591)

(cherry picked from commit 4550cd2)

Co-authored-by: Shlomit-B <76184325+Shlomit-B@users.noreply.github.com>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

kaxil pushed a commit that referenced this pull request Aug 18, 2025
…racing is disabled (#54591) (#54626)

(cherry picked from commit 4550cd2)

Co-authored-by: Shlomit-B <76184325+Shlomit-B@users.noreply.github.com>
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants