Fix AF3 TriggerDagRunLink to handle combinations of base_url #54218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Bug fix]AF3 TriggerDagRunLink
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Do you mind updating the relevant test please.
Otherwise LGTM, cc: @ashb
eladkal
added
the
backport-to-v3-1-test
tirkarthi
reviewed
Aug 9, 2025
ashb
reviewed
Aug 12, 2025
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
Contributor
|
@kandharvishnu couple of tests + static tests are failing on this one, could you please take a look? |
Contributor
Author
Will do it tonight |
Member
This was referenced Aug 13, 2025
amoghrajesh
changed the title
pierrejeambrun
approved these changes
Aug 19, 2025
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 21, 2025
…url (apache#54218) (cherry picked from commit 0204a89) Co-authored-by: kandharvishnu <46064835+kandharvishnu@users.noreply.github.com> Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…54218) Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #54217
With this PR, the broken
TriggerDagRunLinkin AF3 is fixed.Prior to this fix, when the
Triggered DAGbutton in details page is clicked, it will result in broken page.This PR helps to fix this.