Skip to content

Fix AF3 TriggerDagRunLink to handle combinations of base_url #54218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 13 commits into from
Aug 21, 2025
Merged

Fix AF3 TriggerDagRunLink to handle combinations of base_url #54218

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
00593bf
Update helpers.py
kandharvishnu Aug 7, 2025
dc9a419
Merge pull request #4 from kandharvishnu/AF3---TriggerDagRunLink-Fix
kandharvishnu Aug 7, 2025
a4d03c1
Update helpers.py
kandharvishnu Aug 12, 2025
caa4211
Merge branch 'apache:main' into main
kandharvishnu Aug 12, 2025
da0ce5f
Update airflow-core/src/airflow/utils/helpers.py
kandharvishnu Aug 12, 2025
920f865
Update helpers.py
kandharvishnu Aug 12, 2025
aa5b7b8
Update helpers.py
kandharvishnu Aug 13, 2025
68d4943
Update helpers.py
kandharvishnu Aug 13, 2025
2ace816
Update helpers.py
kandharvishnu Aug 14, 2025
e147eaa
Update helpers.py
kandharvishnu Aug 14, 2025
7fc36c8
Merge branch 'main' into main
kandharvishnu Aug 18, 2025
437e7e5
Update airflow-core/src/airflow/utils/helpers.py
kandharvishnu Aug 20, 2025
2af0647
Update helpers.py
kandharvishnu Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/utils/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def build_airflow_dagrun_url(dag_id: str, run_id: str) -> str:
http://localhost:8080/dags/hi/runs/manual__2025-02-23T18:27:39.051358+00:00_RZa1at4Q
"""
baseurl = conf.get("api", "base_url", fallback="/")
return urljoin(baseurl, f"dags/{dag_id}/runs/{run_id}")
return urljoin(baseurl.rstrip("/") + "/", f"dags/{dag_id}/runs/{run_id}")


# The 'template' argument is typed as Any because the jinja2.Template is too
Expand Down
Loading