[v3-0-test] Fix reproducibility issue for tarballs with symlink (#54264) #54267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
Bulk-removing of user and group permissions on MacOS is not a good idea for symlinks for reproducibility, because symlinks on linux cannot have other/group permissions changed but on MacOS they can even if it has no effect. Instead of bulk-change with chmod command we now change the permissions individually on all files except symlinks (cherry picked from commit 7460176) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
force-pushed
the
backport-7460176-v3-0-test
branch
from
ebeb061 to
5396bdf
Compare
Member
|
And .... it's different for Python 3.9 🤯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk-removing of user and group permissions on MacOS is not a good
idea for symlinks for reproducibility, because symlinks on linux
cannot have other/group permissions changed but on MacOS they can
even if it has no effect. Instead of bulk-change with chmod command
we now change the permissions individually on all files except symlinks
(cherry picked from commit 7460176)
Co-authored-by: Jarek Potiuk jarek@potiuk.com