Skip to content

[v3-0-test] Fix reproducibility issue for tarballs with symlink (#54264) #54267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Aug 8, 2025
Merged

[v3-0-test] Fix reproducibility issue for tarballs with symlink (#54264) #54267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions dev/breeze/src/airflow_breeze/utils/reproducible.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import locale
import os
import shutil
import stat
import tarfile
from argparse import ArgumentParser
from pathlib import Path
Expand Down Expand Up @@ -106,15 +107,6 @@ def reset(tarinfo):
if result.returncode != 0:
return result
dest_archive.unlink(missing_ok=True)
result = run_command(
[
"chmod",
"-R",
"go=",
REPRODUCIBLE_PATH.as_posix(),
],
check=False,
)
with cd(REPRODUCIBLE_PATH):
current_dir = "."
file_list = [current_dir]
Expand All @@ -133,6 +125,19 @@ def reset(tarinfo):
with gzip.GzipFile(fileobj=out_file, mtime=0, mode="wb") as gzip_file:
with tarfile.open(fileobj=gzip_file, mode="w:") as tar_file: # type: ignore
for entry in file_list:
entry_path = Path(entry)
if not entry_path.is_symlink():
# For non symlinks clear other and group permission bits,
# keep others unchanged
current_mode = entry_path.stat().st_mode
new_mode = current_mode & ~(stat.S_IRWXO | stat.S_IRWXG)
entry_path.chmod(new_mode)
else:
# for symlinks on the other hand set rwx for all - to match Linux on MacOS
# on platforms like Linux symlink permissions cannot be changed
with contextlib.suppress(NotImplementedError):
# Python 3.9 does not support follow_symlinks
entry_path.lchmod(0o777)
arcname = entry
if prepend_path is not None:
arcname = os.path.normpath(os.path.join(prepend_path, arcname))
Expand Down
Loading