-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Convert auth manager into cachable flag and configure it for more commands #54325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert auth manager into cachable flag and configure it for more commands #54325
Conversation
…mands The `--auth-manager` was only defined for "start-airflow" command so far, and you had to use it every time you wanted to swith to non-default Auth Manager (FabAuthManager). This was not very convenient when you wanted to test things with breeze shell and keep it configured between sessions. After this change: * turns --auth-manager into "CacheableChoice" flag - where last used value is cached in .build folder and reused next time automatically * the flag is now present in those commands: * start-airflow * breeze shell * breeze * You can configure auth manager and change the cached value via `breeze setup config` command - like python/backend etc.
aritra24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a once over, lgtm
gopidesupavan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice :)
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 2770924 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
…mands (apache#54325) The `--auth-manager` was only defined for "start-airflow" command so far, and you had to use it every time you wanted to swith to non-default Auth Manager (FabAuthManager). This was not very convenient when you wanted to test things with breeze shell and keep it configured between sessions. After this change: * turns --auth-manager into "CacheableChoice" flag - where last used value is cached in .build folder and reused next time automatically * the flag is now present in those commands: * start-airflow * breeze shell * breeze * You can configure auth manager and change the cached value via `breeze setup config` command - like python/backend etc. (cherry picked from commit 2770924)
…mands (#54325) (#54330) The `--auth-manager` was only defined for "start-airflow" command so far, and you had to use it every time you wanted to swith to non-default Auth Manager (FabAuthManager). This was not very convenient when you wanted to test things with breeze shell and keep it configured between sessions. After this change: * turns --auth-manager into "CacheableChoice" flag - where last used value is cached in .build folder and reused next time automatically * the flag is now present in those commands: * start-airflow * breeze shell * breeze * You can configure auth manager and change the cached value via `breeze setup config` command - like python/backend etc. (cherry picked from commit 2770924)
…mands (apache#54325) The `--auth-manager` was only defined for "start-airflow" command so far, and you had to use it every time you wanted to swith to non-default Auth Manager (FabAuthManager). This was not very convenient when you wanted to test things with breeze shell and keep it configured between sessions. After this change: * turns --auth-manager into "CacheableChoice" flag - where last used value is cached in .build folder and reused next time automatically * the flag is now present in those commands: * start-airflow * breeze shell * breeze * You can configure auth manager and change the cached value via `breeze setup config` command - like python/backend etc.



The
--auth-managerwas only defined for "start-airflow" command so far, and you had to use it every time you wanted to swith to non-default Auth Manager (FabAuthManager). This was not very convenient when you wanted to test things with breeze shell and keep it configured between sessions.After this change:
turns --auth-manager into "CacheableChoice" flag - where last used value is cached in .build folder and reused next time automatically
the flag is now present in those commands:
You can configure auth manager and change the cached value via
breeze setup configcommand - like python/backend etc.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.