[v3-0-test] Convert auth manager into cachable flag and configure it for more com… #54330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mands (apache#54325) The `--auth-manager` was only defined for "start-airflow" command so far, and you had to use it every time you wanted to swith to non-default Auth Manager (FabAuthManager). This was not very convenient when you wanted to test things with breeze shell and keep it configured between sessions. After this change: * turns --auth-manager into "CacheableChoice" flag - where last used value is cached in .build folder and reused next time automatically * the flag is now present in those commands: * start-airflow * breeze shell * breeze * You can configure auth manager and change the cached value via `breeze setup config` command - like python/backend etc. (cherry picked from commit 2770924)
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mands (#54325)
The
--auth-managerwas only defined for "start-airflow" command so far, and you had to use it every time you wanted to swith to non-default Auth Manager (FabAuthManager). This was not very convenient when you wanted to test things with breeze shell and keep it configured between sessions.After this change:
turns --auth-manager into "CacheableChoice" flag - where last used value is cached in .build folder and reused next time automatically
the flag is now present in those commands:
You can configure auth manager and change the cached value via
breeze setup configcommand - like python/backend etc.(cherry picked from commit 2770924)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.