-
Notifications
You must be signed in to change notification settings - Fork 16.3k
To fix Fab auth manager returns get_id of integer type where str is expected #54384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a test case for it
|
added the test case |
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the catch!
providers/fab/tests/unit/fab/auth_manager/models/test_user_model.py
Outdated
Show resolved
Hide resolved
|
nice pr :) |
I guess str, int difference doesn't really matter in these cases 🤔 |
vincbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit but overall LGTM
providers/fab/tests/unit/fab/auth_manager/models/test_user_model.py
Outdated
Show resolved
Hide resolved
b735b53 to
22cb68b
Compare
|
As AIP-90 kinda needs this, I just updated the tests. Since I modified part of the code, it would be nice if @jason810496 or @vincbeck could take another look and merge it if there's no issue :) |
|
cc @KevinYang21 |
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…xpected (apache#54384) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
…xpected (apache#54384) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
This closes Fab auth manager returns get_id of integer type where str is expected #54298
closes: #54298
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.