Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,8 @@ def perms(self):
}
return self._perms

def get_id(self):
return self.id
def get_id(self) -> str:
return str(self.id)

def get_name(self) -> str:
return self.username or self.email or self.user_id
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

import pytest

from airflow.providers.fab.auth_manager.models import User

pytestmark = pytest.mark.db_test


@pytest.mark.parametrize(
"user_id, expected_id",
[
(999, "999"),
("999", "999"),
],
)
def test_get_id_returns_str(user_id: int | str, expected_id: str) -> None:
"""
Ensure get_id() always returns a string representation of the id.
"""
user = User()
user.id = user_id
result = user.get_id()
assert isinstance(result, str), f"Expected str, got {type(result)}"
assert result == expected_id
Loading