Fix prek teething errors for canary builds #54583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
requested review from
aritra24,
eladkal,
jedcunningham,
jscheffl and
shahar1
jscheffl
approved these changes
Aug 17, 2025
potiuk
force-pushed
the
fix-prek-canary-builds-integration
branch
from
b7cdee4 to
7b71dd7
Compare
Member
Author
|
I added link to j178/prek#35 in the TODO |
eladkal
approved these changes
Aug 17, 2025
After switching to prek in apache#54258 there are still few small things thet were only discovered in our canary builds: * installation of prek hooks does not necessarily create uv cache * autoupgrade is not yet implemented in prek
potiuk
force-pushed
the
fix-prek-canary-builds-integration
branch
from
7b71dd7 to
eed3966
Compare
aritra24
approved these changes
Aug 17, 2025
bugraoz93
approved these changes
Aug 17, 2025
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 703af5e v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
After switching to prek in apache#54258 there are still few small things thet were only discovered in our canary builds: * installation of prek hooks does not necessarily create uv cache * autoupgrade is not yet implemented in prek (cherry picked from commit 703af5e) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After switching to prek in #54258 there are still few small things thet were only discovered in our canary builds:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.