Switch pre-commit to prek #54258
Merged
Switch pre-commit to prek #54258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:airflow-ctl
area:dev-tools
area:production-image
potiuk
force-pushed
the
switch-pre-commit-to-prefligit
branch
from
e4992b0 to
d0eef21
Compare
Member
|
👀 cool :) |
potiuk
force-pushed
the
switch-pre-commit-to-prefligit
branch
2 times, most recently
from
8e3d557 to
19f73a8
Compare
potiuk
force-pushed
the
switch-pre-commit-to-prefligit
branch
4 times, most recently
from
17a5f34 to
5080dfb
Compare
potiuk
force-pushed
the
switch-pre-commit-to-prefligit
branch
from
5080dfb to
b33b234
Compare
Open
potiuk
force-pushed
the
switch-pre-commit-to-prefligit
branch
2 times, most recently
from
8a252cb to
ed86d67
Compare
Member
j178
reviewed
Aug 13, 2025
potiuk
force-pushed
the
switch-pre-commit-to-prefligit
branch
from
ed86d67 to
9329928
Compare
potiuk
requested review from
amoghrajesh,
ashb,
bolkedebruin,
gopidesupavan,
jason810496,
kaxil and
pierrejeambrun
as code owners
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 3442d81 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Member
Author
|
Wooohooo.. Merged! ... |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
After switching to prek in apache#54258 there are still few small things thet were only discovered in our canary builds: * installation of prek hooks does not necessarily create uv cache * autoupgrade is not yet implemented in prek
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
After switching to prek in apache#54258 there are still few small things thet were only discovered in our canary builds: * installation of prek hooks does not necessarily create uv cache * autoupgrade is not yet implemented in prek
This was referenced Aug 17, 2025
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
After switching to prek in apache#54258 there are still few small things thet were only discovered in our canary builds: * installation of prek hooks does not necessarily create uv cache * autoupgrade is not yet implemented in prek
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
The pre-commit is a fantastic tool, and we heavily used it for years, but generally the tool stagnated and is not showing a sign of adapting to our needs. For years we tried to convince pre-commit maintainers that things like autocomplete are necessary - but it met with pretty much resistance (if not hostility) from the maintainer. Also there was no chance for them to accept expectations of bigger projects like ours, where we have a huge monorepo and not only multiple needs but also different parts of the repo needing different language support (golang, typescript soon) - and apparenty the maintainer of pre-commit does not think monorepo is a good thing at all. Similarly - they did not recognize the raise of `uv` and the only way to use `uv` with pre-commit is to patch it by installing `pre-comit-uv` that essentialy patches pre-commit with uv support. This is not really sustainable and the tool lags behind many of our needs. Luckily - we have new project in town - prek - which rewrites pre-commit that is 100% compatible (now), 10x faster (because rust), uses `uv` natively, supports auto-complete already and they have very friendly maintainer who is not only supporting us but also very happily works on improving `prek` to close all the gaps, and plans to implement (with our support of course and cooperation) monorepo support - that will allow us to modularise our pre-commits. This PR switches our pre-commit support to use prek exclusively: * breeze static checks command is completely removed * custom auto-complete code in breeze as well * instructions are updated to setup prek instead of precommit * CI is updated to run prek instead of pre-commmit * documentation for static checks is reviewed and new features that prek enables are added (cherry picked from commit 3442d81)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
The pre-commit is a fantastic tool, and we heavily used it for years, but generally the tool stagnated and is not showing a sign of adapting to our needs. For years we tried to convince pre-commit maintainers that things like autocomplete are necessary - but it met with pretty much resistance (if not hostility) from the maintainer. Also there was no chance for them to accept expectations of bigger projects like ours, where we have a huge monorepo and not only multiple needs but also different parts of the repo needing different language support (golang, typescript soon) - and apparenty the maintainer of pre-commit does not think monorepo is a good thing at all. Similarly - they did not recognize the raise of `uv` and the only way to use `uv` with pre-commit is to patch it by installing `pre-comit-uv` that essentialy patches pre-commit with uv support. This is not really sustainable and the tool lags behind many of our needs. Luckily - we have new project in town - prek - which rewrites pre-commit that is 100% compatible (now), 10x faster (because rust), uses `uv` natively, supports auto-complete already and they have very friendly maintainer who is not only supporting us but also very happily works on improving `prek` to close all the gaps, and plans to implement (with our support of course and cooperation) monorepo support - that will allow us to modularise our pre-commits. This PR switches our pre-commit support to use prek exclusively: * breeze static checks command is completely removed * custom auto-complete code in breeze as well * instructions are updated to setup prek instead of precommit * CI is updated to run prek instead of pre-commmit * documentation for static checks is reviewed and new features that prek enables are added (cherry picked from commit 3442d81)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
After switching to prek in apache#54258 there are still few small things thet were only discovered in our canary builds: * installation of prek hooks does not necessarily create uv cache * autoupgrade is not yet implemented in prek
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
The pre-commit is a fantastic tool, and we heavily used it for years, but generally the tool stagnated and is not showing a sign of adapting to our needs. For years we tried to convince pre-commit maintainers that things like autocomplete are necessary - but it met with pretty much resistance (if not hostility) from the maintainer. Also there was no chance for them to accept expectations of bigger projects like ours, where we have a huge monorepo and not only multiple needs but also different parts of the repo needing different language support (golang, typescript soon) - and apparenty the maintainer of pre-commit does not think monorepo is a good thing at all. Similarly - they did not recognize the raise of `uv` and the only way to use `uv` with pre-commit is to patch it by installing `pre-comit-uv` that essentialy patches pre-commit with uv support. This is not really sustainable and the tool lags behind many of our needs. Luckily - we have new project in town - prek - which rewrites pre-commit that is 100% compatible (now), 10x faster (because rust), uses `uv` natively, supports auto-complete already and they have very friendly maintainer who is not only supporting us but also very happily works on improving `prek` to close all the gaps, and plans to implement (with our support of course and cooperation) monorepo support - that will allow us to modularise our pre-commits. This PR switches our pre-commit support to use prek exclusively: * breeze static checks command is completely removed * custom auto-complete code in breeze as well * instructions are updated to setup prek instead of precommit * CI is updated to run prek instead of pre-commmit * documentation for static checks is reviewed and new features that prek enables are added (cherry picked from commit 3442d81)
potiuk
added a commit
that referenced
this pull request
Aug 17, 2025
After switching to prek in #54258 there are still few small things thet were only discovered in our canary builds: * installation of prek hooks does not necessarily create uv cache * autoupgrade is not yet implemented in prek
potiuk
added a commit
that referenced
this pull request
Aug 17, 2025
The pre-commit is a fantastic tool, and we heavily used it for years, but generally the tool stagnated and is not showing a sign of adapting to our needs. For years we tried to convince pre-commit maintainers that things like autocomplete are necessary - but it met with pretty much resistance (if not hostility) from the maintainer. Also there was no chance for them to accept expectations of bigger projects like ours, where we have a huge monorepo and not only multiple needs but also different parts of the repo needing different language support (golang, typescript soon) - and apparenty the maintainer of pre-commit does not think monorepo is a good thing at all. Similarly - they did not recognize the raise of `uv` and the only way to use `uv` with pre-commit is to patch it by installing `pre-comit-uv` that essentialy patches pre-commit with uv support. This is not really sustainable and the tool lags behind many of our needs. Luckily - we have new project in town - prek - which rewrites pre-commit that is 100% compatible (now), 10x faster (because rust), uses `uv` natively, supports auto-complete already and they have very friendly maintainer who is not only supporting us but also very happily works on improving `prek` to close all the gaps, and plans to implement (with our support of course and cooperation) monorepo support - that will allow us to modularise our pre-commits. This PR switches our pre-commit support to use prek exclusively: * breeze static checks command is completely removed * custom auto-complete code in breeze as well * instructions are updated to setup prek instead of precommit * CI is updated to run prek instead of pre-commmit * documentation for static checks is reviewed and new features that prek enables are added (cherry picked from commit 3442d81)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2025
After switching to prek in apache#54258 there are still few small things thet were only discovered in our canary builds: * installation of prek hooks does not necessarily create uv cache * autoupgrade is not yet implemented in prek (cherry picked from commit 703af5e) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
kaxil
pushed a commit
that referenced
this pull request
Aug 18, 2025
The pre-commit is a fantastic tool, and we heavily used it for years, but generally the tool stagnated and is not showing a sign of adapting to our needs. For years we tried to convince pre-commit maintainers that things like autocomplete are necessary - but it met with pretty much resistance (if not hostility) from the maintainer. Also there was no chance for them to accept expectations of bigger projects like ours, where we have a huge monorepo and not only multiple needs but also different parts of the repo needing different language support (golang, typescript soon) - and apparenty the maintainer of pre-commit does not think monorepo is a good thing at all. Similarly - they did not recognize the raise of `uv` and the only way to use `uv` with pre-commit is to patch it by installing `pre-comit-uv` that essentialy patches pre-commit with uv support. This is not really sustainable and the tool lags behind many of our needs. Luckily - we have new project in town - prek - which rewrites pre-commit that is 100% compatible (now), 10x faster (because rust), uses `uv` natively, supports auto-complete already and they have very friendly maintainer who is not only supporting us but also very happily works on improving `prek` to close all the gaps, and plans to implement (with our support of course and cooperation) monorepo support - that will allow us to modularise our pre-commits. This PR switches our pre-commit support to use prek exclusively: * breeze static checks command is completely removed * custom auto-complete code in breeze as well * instructions are updated to setup prek instead of precommit * CI is updated to run prek instead of pre-commmit * documentation for static checks is reviewed and new features that prek enables are added
37 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 7, 2026
When we switched to prek in apache#54258, we accidentally missed the `^` after from ref - which turned the basic checks to do checks on empty set of changes.
potiuk
added a commit
that referenced
this pull request
Jan 7, 2026
When we switched to prek in #54258, we accidentally missed the `^` after from ref - which turned the basic checks to do checks on empty set of changes.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 7, 2026
…che#60202) When we switched to prek in apache#54258, we accidentally missed the `^` after from ref - which turned the basic checks to do checks on empty set of changes. (cherry picked from commit 898045f) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Jan 7, 2026
61 tasks
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
When we switched to prek in apache#54258, we accidentally missed the `^` after from ref - which turned the basic checks to do checks on empty set of changes.
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
When we switched to prek in apache#54258, we accidentally missed the `^` after from ref - which turned the basic checks to do checks on empty set of changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.