Skip to content

Conversation

@johnslavik
Copy link
Contributor

@johnslavik johnslavik commented Dec 1, 2025

The ./scripts/tools/setup_breeze script fails to install autocompletions. To reproduce:

Details
❯ which breeze &>/dev/null && rm -vf $(which breeze)
removed '/home/bswck/.local/bin/breeze'
 
❯ ./scripts/tools/setup_breeze 

The 'breeze' is not on path. Breeze should be installed and 'breeze' should be available on your PATH!

Installing Breeze. This will install breeze via uv and modify your /bin/bash to run it


Please confirm installing and modifying the startup scripts. Are you sure? [y/N/q]
y
The answer is 'yes'. installing and modifying the startup scripts. This can take some time!
Resolved 108 packages in 28ms
Uninstalled 1 package in 1ms
Installed 1 package in 7ms
 ~ apache-airflow-breeze==0.0.1 (from file:///home/bswck/Apache/airflow/dev/breeze)
Installed 1 executable: breeze
                                                                                                                                                                
 Usage: breeze [OPTIONS] COMMAND [ARGS]...                                                                                                                      
                                                                                                                                                                
                                                                                                                                                                
 Try running the '--help' flag for more information.                                                                                                            
                                                                                                                                                                
╭─ Error ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ No such command 'setup-autocomplete'.                                                                                                                        │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
                                                                                                                                                                
                                                                                                                                                                
 To find out more, visit https://github.com/apache/airflow/blob/main/dev/breeze/doc/01_installation.rst

In #25449, the setup-autocomplete command became setup autocomplete, but ${BREEZE_BINARY} setup-autocomplete in the setup script (which used to be ./breeze back then) wasn't fixed up -- 31fb5ff#diff-7e92c11499fd4106a899eeb457db8277bd6f09dd29e683f33ae704e12fa29caeR73. A trickier one :)

I've fixed the old-fashion command invocation, and I've corrected the remaining stale references to setup-autocomplete in the docs.

You shouldn't find setup-autocomplete now anywhere but in CSS class names.

cc @potiuk (hi! 😁)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 1, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Dec 1, 2025
@johnslavik
Copy link
Contributor Author

johnslavik commented Dec 1, 2025

To follow up on this in the future, do you think it's worth it to cover this and similar paths of such setup scripts (and their examples in the docs) with some tests, just in case? I could file an issue to track.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@potiuk
Copy link
Member

potiuk commented Dec 1, 2025

Interesting. Main reason why it was not working was that recently - in August - #54258 when I removed some very, very old deprecated commands (setup-autocomplete was something that was there initially and we had deprecated command still available till August).

To follow up on this in the future, do you think it's worth it to cover this and similar paths of such setup scripts (and their examples in the docs) with some tests, just in case? I could file an issue to track.

Actually this is one of the very few scripts not covered by CI - and I take it almost as a pride point to test all those scripts. This one has not been tested, because it was mostly a helper. But ABSOLUTELY .... Feel free to add it to our CI :)

@potiuk potiuk merged commit c116edc into apache:main Dec 1, 2025
98 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 1, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@potiuk
Copy link
Member

potiuk commented Dec 1, 2025

Thanks my friend BTW. Glad to see you here :)

github-actions bot pushed a commit that referenced this pull request Dec 1, 2025
* Fix `setup autocomplete` invocation

* Correct autocomplete command tip
(cherry picked from commit c116edc)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

potiuk pushed a commit that referenced this pull request Dec 1, 2025
* Fix `setup autocomplete` invocation

* Correct autocomplete command tip
(cherry picked from commit c116edc)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@johnslavik
Copy link
Contributor Author

Feel free to add it to our CI :)

🫡

ephraimbuddy pushed a commit that referenced this pull request Dec 3, 2025
* Fix `setup autocomplete` invocation

* Correct autocomplete command tip
(cherry picked from commit c116edc)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Dec 3, 2025
* Fix `setup autocomplete` invocation

* Correct autocomplete command tip
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
* Fix `setup autocomplete` invocation

* Correct autocomplete command tip
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
* Fix `setup autocomplete` invocation

* Correct autocomplete command tip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants