[v3-0-test] Fix conditionals for test types and make them consistent (#54678) #54691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go tests do not depend on CI image being built, also they should not be run independently on the `run-tests` flag - because run-tests is generally for our unit tests. They should be run when `run-go-sdk-tests` is set and without dependency on ci-images being built. There were also a few other issues found during this cleanuup: Several outputs were inconsistently named: * run-tests was renamed to run-unit-tests * need-* outputs were renamed to run-* Some other fixes were applied: * only-new-ui-files was removed as it is not needed any more as we do not really need that check to be exposed to actions, it is only used internally - to not run other tests when only ui files changed * run-system-tests was not properly used (it is currently an alias to run-unit-tests anyway - but foreseen for future separation$a * need-javascript-scans and need-python-scans have been removed as they are no longer used (cherry picked from commit 9460976)
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go tests do not depend on CI image being built, also they should not be run independently on the
run-testsflag - because run-tests is generally for our unit tests.They should be run when
run-go-sdk-testsis set and without dependency on ci-images being built. There were also a few other issues found during this cleanuup:Several outputs were inconsistently named:
Some other fixes were applied:
(cherry picked from commit 9460976)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.