Add pendingActions onto ui/dags #55041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
bbovenzi
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
pierrejeambrun,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
Author
|
Need to do some more "Required Actions" -> "Needs Review" renaming but in another PR |
jscheffl
reviewed
Aug 29, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Filter looks good in general but ... naming is hard. I am not 100% OK with "Needs Review". Functional and Code is perfect!
airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/StateFilters.tsx
Outdated
Show resolved
Hide resolved
jason810496
reviewed
Aug 30, 2025
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/dags.py
Outdated
Show resolved
Hide resolved
Contributor
|
If you plan to merge it before the 3.1 release, please consider my comment in this PR: #55119 (comment) |
Member
sure :) |
Lee-W
force-pushed
the
hitl-on-dags-list
branch
from
b1421c8 to
f695cba
Compare
Lee-W
force-pushed
the
hitl-on-dags-list
branch
from
ddf2906 to
d9597b7
Compare
pierrejeambrun
approved these changes
Sep 2, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Just one nit, but looks good. Thanks.
airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_dags.py
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks for the reminder. I'll try to reduce the i18n surface area of this PR and keep any renaming discussion on a follow up branch. |
github-project-automation
bot
moved this from In review
to Done
in AIP-90 - Human in the loop
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Add pendingActions onto ui/dags * refactor(api_fastapi): unify usage of the term Dag * refactor(api_fastapi): simplify HITL loading logic * test: add test case test_should_return_200_with_hitl * Refactor naming scheme and filter * fix(hitl): fix has_pending_actions to use >= 1 and == 0 to query * feat(zh-tw): update Taiwanese Mandarin translation * Reduce i18n surface area and parameterize dags test --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #54961
Add hitl that need reviews as
pending_actionson ui/dags. Show "Needs Review" as a badge on the dags list. Allow a user to filter the dags list to only show dags that need review. Dashboard link now redirects to the dags list filtered.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.