Implement default language (English) freeze pre-commit #55119
Conversation
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
shahar1
force-pushed
the
default-language-freeze-pre-commit
branch
2 times, most recently
from
6915dff to
6661aac
Compare
|
It would be great if we can get #55041 merged before this |
|
did a quick fix for the missing import |
shahar1
force-pushed
the
default-language-freeze-pre-commit
branch
from
c79a6d6 to
9db9425
Compare
shahar1
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
|
After a second thought, should we set time zone as AoE instead? |
shahar1
force-pushed
the
default-language-freeze-pre-commit
branch
from
faecc2f to
8b6a6e2
Compare
Thanks! I also realized that it didn't actually check if there was a difference in the files during these dates, so I added a "git diff" call :)
The idea of the freeze is to align all translations against a constant source, so translation owners would be able to complete the gaps without "chasing" after the new changes every day until the release. To avoid blocking new features during this time, we could create an "exemption list" in a separate JSON file with the file names as keys. The translation owners won't be required to translate changes from this file and it will also be excluded from the completeness calculation. By the end of the freeze - we should relocate the terms from this file to their appropriate place. The trade-off for this flexibility is that terms might be missing from translations in the upcoming release, and we create a small debt to handle the list afterwards (we could relatively easily automate that). @Lee-W @kaxil @potiuk @jscheffl @bbovenzi What do you all think?
I wasn't aware that this term exists :D I'm ok with that, I assume that few hours to here and there won't make a significant difference. |
Works for me :)
I learned this from the Python community, probably EuroPython. I find it very inclusive and it makes everyone's day easier, especially in a cross-timezone community. That's why I'm kinda a promoter of this idea haha |
Nice :) Comment: do we need the dates here at ALL ? I think it will be enough if we just enable "freeze" in this commit and then "disable" it by a second commit after we unfroze it. While the dates are nice from informational point of view (and we should leave them in in the messages, this one gives us extra flexibility - because we can unfreeze it deliberately rather than automatically |
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
* Implement default language (English) freeze pre-commit * fix: fix missing import * Add git diff * Create freeze exemptions * Change to AoE --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
) This is follow-up after apache#55119 - implements the translation freeze quite a bit simpler and faster: * uses selective checks (fail fast) * does not check the dates (we will set the flag to False when freeze time passes * you can bypass the freeze with a label rather than having to commit exemption file
3 participants
Following the recent dev call, this PR introduces a pre-commit to prevent changes in the default language during freeze time. The current freeze will be between Sep. 1 to Sep 9 (inc.); all times are arbitrarily measured in
UTCAoE time.This pre-commit should be reused in later freezes simply by changing the dates (I'll add it to the i18n policy).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.