Skip to content

Conversation

@olegkachur-e
Copy link
Contributor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@olegkachur-e olegkachur-e force-pushed the disable_beam_links_for_direct_runners branch 2 times, most recently from 8be0f70 to 87fff5b Compare September 5, 2025 09:28
@potiuk
Copy link
Member

potiuk commented Sep 6, 2025

Same here. We almost never accept PRs without unit tests to prevent regressions.

@olegkachur-e olegkachur-e force-pushed the disable_beam_links_for_direct_runners branch 3 times, most recently from 95e5bf3 to 91e93d6 Compare September 10, 2025 13:08
@olegkachur-e olegkachur-e force-pushed the disable_beam_links_for_direct_runners branch from 91e93d6 to e4ad088 Compare September 11, 2025 07:44
@olegkachur-e
Copy link
Contributor Author

Same here. We almost never accept PRs without unit tests to prevent regressions.

Added the accompanying tests.

@VladaZakharova
Copy link
Contributor

hi @potiuk can you please check this one too ? :)

@potiuk potiuk merged commit d62f992 into apache:main Sep 12, 2025
73 checks passed
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants