Skip to content

Disable links for beam provider operators using non-dataflow runner #55248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Sep 12, 2025
Merged

Disable links for beam provider operators using non-dataflow runner #55248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions providers/apache/beam/src/airflow/providers/apache/beam/operators/beam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,10 @@ def execute(self, context: Context):
if not self.beam_hook:
raise AirflowException("Beam hook is not defined.")

if self.runner.lower() != BeamRunnerType.DataflowRunner.lower():
# Links are rendered only for dataflow runner
self.operator_extra_links = ()

if self.deferrable and not self.is_dataflow:
self.defer(
trigger=BeamPythonPipelineTrigger(
Expand Down Expand Up @@ -577,6 +581,9 @@ def execute(self, context: Context):
) = self._init_pipeline_options()
if not self.beam_hook:
raise AirflowException("Beam hook is not defined.")
if self.runner.lower() != BeamRunnerType.DataflowRunner.lower():
# Links are rendered only for dataflow runner
self.operator_extra_links = ()

if self.deferrable and not self.is_dataflow:
self.defer(
Expand Down
28 changes: 28 additions & 0 deletions providers/apache/beam/tests/unit/apache/beam/operators/test_beam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,19 @@ def test_exec_direct_runner(self, gcs_hook, beam_hook_mock, py_options):
py_system_site_packages=False,
)

@mock.patch(BEAM_OPERATOR_PATH.format("BeamHook"))
@mock.patch(BEAM_OPERATOR_PATH.format("GCSHook"))
def test_direct_runner_no_op_extra_links(self, gcs_hook, beam_hook_mock, py_options):
"""Test there is no operator_extra_links when running pipeline with direct runner type."""
start_python_hook = beam_hook_mock.return_value.start_python_pipeline
op = BeamRunPythonPipelineOperator(**self.default_op_kwargs)
op.execute({})

beam_hook_mock.assert_called_once_with(runner=DEFAULT_RUNNER)
start_python_hook.assert_called_once()

assert not op.operator_extra_links

@mock.patch(BEAM_OPERATOR_PATH.format("DataflowJobLink.persist"))
@mock.patch(BEAM_OPERATOR_PATH.format("BeamHook"))
@mock.patch(BEAM_OPERATOR_PATH.format("DataflowHook"))
Expand Down Expand Up @@ -403,6 +416,21 @@ def test_exec_direct_runner(self, gcs_hook, beam_hook_mock, default_options, pip
job_class=JOB_CLASS,
)

@mock.patch(BEAM_OPERATOR_PATH.format("BeamHook"))
@mock.patch(BEAM_OPERATOR_PATH.format("GCSHook"))
def test_direct_runner_no_op_extra_links(
self, gcs_hook, beam_hook_mock, default_options, pipeline_options
):
"""Test there is no operator_extra_links when running pipeline with direct runner type."""
start_java_hook = beam_hook_mock.return_value.start_java_pipeline
op = BeamRunJavaPipelineOperator(**self.default_op_kwargs)

op.execute({})

beam_hook_mock.assert_called_once_with(runner=DEFAULT_RUNNER)
start_java_hook.assert_called_once()
assert not op.operator_extra_links

@mock.patch(BEAM_OPERATOR_PATH.format("DataflowJobLink.persist"))
@mock.patch(BEAM_OPERATOR_PATH.format("BeamHook"))
@mock.patch(BEAM_OPERATOR_PATH.format("DataflowHook"))
Expand Down