Add worker maintenance mode functionality to Edge3 provider UI #55301

dheerajturaga · 2025-09-05T15:27:02Z

Add POST /edge_worker/ui/worker/{worker_name}/maintenance endpoint to request maintenance mode
Add DELETE /edge_worker/ui/worker/{worker_name}/maintenance endpoint to exit maintenance mode
Add maintenance request form with required comment field (max 1024 chars)
Add maintenance state handling for all maintenance-related worker states
Add proper error handling and user feedback for maintenance operations
Add worker existence validation and database session management
Remove authentication dependencies for UI maintenance endpoints
Update frontend to show maintenance controls based on worker state
Format maintenance comments with timestamps for audit trail

Expect more beautification in additional PRs, this is bringing in base functionality

- Add POST /edge_worker/ui/worker/{worker_name}/maintenance endpoint to request maintenance mode - Add DELETE /edge_worker/ui/worker/{worker_name}/maintenance endpoint to exit maintenance mode - Add maintenance request form with required comment field (max 1024 chars) - Add maintenance state handling for all maintenance-related worker states - Add proper error handling and user feedback for maintenance operations - Add worker existence validation and database session management - Remove authentication dependencies for UI maintenance endpoints - Update frontend to show maintenance controls based on worker state - Format maintenance comments with timestamps for audit trail

jscheffl

Very cool! I also wanted to get started with the maintenance but you opened the PR faster. Cool!
Functionally the skeleton is working.

Sorry about the many comments, don't be afraid. If too much then let me know and I can also contribute to this as this is an important feature urgently needed in UI for Airflow 3.1 release.

providers/edge3/src/airflow/providers/edge3/worker_api/routes/ui.py

providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/WorkerPage.tsx

Remove explicit session.commit() calls - let SQLAlchemy handle transactions

- Move MaintenanceRequest class to datamodels_ui.py for better organization - Remove explicit session.commit() calls, let SQLAlchemy handle transactions - Extract OperationsCell and MaintenanceForm into separate component file - Clean up unused imports in WorkerPage.tsx - Improve code modularity and maintainability

…tenance operations - Use useUiServiceRequestWorkerMaintenance and useUiServiceExitWorkerMaintenance hooks - Remove manual fetch implementation with CSRF token handling - Simplify error handling using React Query's onSuccess/onError callbacks - Improve type safety with generated API client - Reduce bundle size and code complexity - Maintain same functionality with cleaner, more maintainable code

jscheffl

I was not able to commit to your repo, Github gave me the following error :-(

jscheffl@hp860g9:~/Workspace/airflow_review$ git push
error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'github.com:dheerajturaga/airflow.git'

Therefore (1) added commits 1-3 from my additions as recommondations/comments. Did not pply them because generated and compiled code was not possible to be added by this ... you need to apply and compile UI.

Alternatively opened a DRAFT PR, you can also easily git cherry-pick from there:
#55348:

My change attempt to make a proper dialog in commit 4 / Rework maintenance dialog to be a dialog as not successful, asked in Slack if I am tooo stupid... I assume to need help on this.
So to un-block the efforts, maybe if commits 1-3 are cherry picked it is OK to merge and then applying beautification later?

providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/OperationsCell.tsx

providers/edge3/src/airflow/providers/edge3/worker_api/routes/ui.py

dheerajturaga · 2025-09-07T17:50:44Z

I was not able to commit to your repo, Github gave me the following error :-(
jscheffl@hp860g9:~/Workspace/airflow_review$ git push

error: Authentication error: Authentication required: You must have push access to verify locks

error: failed to push some refs to 'github.com:dheerajturaga/airflow.git'
Therefore (1) added commits 1-3 from my additions as recommondations/comments. Did not pply them because generated and compiled code was not possible to be added by this ... you need to apply and compile UI.

Alternatively opened a DRAFT PR, you can also easily git cherry-pick from there:

#55348:

Add tooltips to buttons

Have exit button not if it is in maintenance exit already

Add authentication to (new) API endpoints

My change attempt to make a proper dialog in commit 4 / Rework maintenance dialog to be a dialog as not successful, asked in Slack if I am tooo stupid... I assume to need help on this.

So to un-block the efforts, maybe if commits 1-3 are cherry picked it is OK to merge and then applying beautification later?

@jscheffl sure thing! Let me cherry pick these and re compile the assets in a couple of hours. Lets merge if base functionality is available and cleanup the UI in subsequent PRs

dheerajturaga · 2025-09-07T20:19:57Z

@jscheffl, I updated the PR with latest screenshots

jscheffl

Looks good!

…e#55301) * Add worker maintenance mode functionality to Edge3 provider UI - Add POST /edge_worker/ui/worker/{worker_name}/maintenance endpoint to request maintenance mode - Add DELETE /edge_worker/ui/worker/{worker_name}/maintenance endpoint to exit maintenance mode - Add maintenance request form with required comment field (max 1024 chars) - Add maintenance state handling for all maintenance-related worker states - Add proper error handling and user feedback for maintenance operations - Add worker existence validation and database session management - Remove authentication dependencies for UI maintenance endpoints - Update frontend to show maintenance controls based on worker state - Format maintenance comments with timestamps for audit trail * Move MaintenanceRequest to datamodels_ui.py for better code organization Remove explicit session.commit() calls - let SQLAlchemy handle transactions * refactor: extract OperationsCell into separate component - Move MaintenanceRequest class to datamodels_ui.py for better organization - Remove explicit session.commit() calls, let SQLAlchemy handle transactions - Extract OperationsCell and MaintenanceForm into separate component file - Clean up unused imports in WorkerPage.tsx - Improve code modularity and maintainability * refactor: replace manual fetch with generated axios wrappers for maintenance operations - Use useUiServiceRequestWorkerMaintenance and useUiServiceExitWorkerMaintenance hooks - Remove manual fetch implementation with CSRF token handling - Simplify error handling using React Query's onSuccess/onError callbacks - Improve type safety with generated API client - Reduce bundle size and code complexity - Maintain same functionality with cleaner, more maintainable code * Use react icons instead of old school buttons * Add tooltips to buttons * Have exit button not if it is in maintenance exit already * Add authentication to (new) API endpoints --------- Co-authored-by: Jens Scheffler <jscheffl@apache.org>

dheerajturaga requested a review from jscheffl as a code owner September 5, 2025 15:27

boring-cyborg bot added area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Sep 5, 2025

dheerajturaga force-pushed the feature/edge-maintenance-plugin branch from 4fc6780 to 39024c2 Compare September 5, 2025 18:51

jscheffl reviewed Sep 5, 2025

View reviewed changes

dheerajturaga added 4 commits September 5, 2025 18:04

Move MaintenanceRequest to datamodels_ui.py for better code organization

9a3ba47

Remove explicit session.commit() calls - let SQLAlchemy handle transactions

Use react icons instead of old school buttons

b9015bc

jscheffl reviewed Sep 7, 2025

View reviewed changes

jscheffl added 3 commits September 7, 2025 13:54

Add tooltips to buttons

296223d

Have exit button not if it is in maintenance exit already

10cb3b7

Add authentication to (new) API endpoints

ba2a5d2

jscheffl approved these changes Sep 7, 2025

View reviewed changes

jscheffl merged commit acc1765 into apache:main Sep 7, 2025
133 of 134 checks passed

dheerajturaga deleted the feature/edge-maintenance-plugin branch September 7, 2025 20:54

eladkal mentioned this pull request Sep 18, 2025

Status of testing Providers that were prepared on September 18, 2025 #55831

Closed

78 tasks

Add worker maintenance mode functionality to Edge3 provider UI #55301

Add worker maintenance mode functionality to Edge3 provider UI #55301

Uh oh!

Conversation

dheerajturaga commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jscheffl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jscheffl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dheerajturaga commented Sep 7, 2025

Uh oh!

dheerajturaga commented Sep 7, 2025

Uh oh!

jscheffl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dheerajturaga commented Sep 5, 2025 •

edited

Loading