Feature/edge maintenance plugin beautification #55348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:edge
jscheffl
force-pushed
the
feature/edge-maintenance-plugin-beautification
branch
from
988adf2 to
cb201e5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the edge worker maintenance UI from an inline form to a dialog-based interface, improving user experience with better visual presentation and interaction patterns.
- Replaces inline maintenance form with a dedicated dialog component
- Separates maintenance operations into individual button components
- Fixes React DOM dependency issues for proper dialog rendering
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| www-hash.txt | Updates hash for built web assets |
| ui.py | Adds status code constants and maintenance comment validation |
| vite.config.ts | Adds ReactDOM global for external library compatibility |
| WorkerPage.tsx | Refactors to use new WorkerOperations component |
| WorkerOperations.tsx | New component orchestrating maintenance operations |
| OperationsCell.tsx | Removes old inline form implementation |
| MaintenanceExitButton.tsx | New component for exiting maintenance mode |
| MaintenanceEnterButton.tsx | New component with dialog for entering maintenance |
| main.tsx | Exposes ReactDOM globally for plugin compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ders/edge3/src/airflow/providers/edge3/plugins/www/src/components/MaintenanceEnterButton.tsx
Show resolved
Hide resolved
...ders/edge3/src/airflow/providers/edge3/plugins/www/src/components/MaintenanceEnterButton.tsx
Outdated
Show resolved
Hide resolved
...ders/edge3/src/airflow/providers/edge3/plugins/www/src/components/MaintenanceEnterButton.tsx
Show resolved
Hide resolved
Member
|
Cool! Nice and clean UI. I like it 
|
jscheffl
added
type:bug-fix
jscheffl
force-pushed
the
feature/edge-maintenance-plugin-beautification
branch
from
fbb4116 to
5eee9f4
Compare
jscheffl
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
kaxil
approved these changes
Sep 8, 2025
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Mainly a rubber stamp for merge. Backend changes looks good
dheerajturaga
approved these changes
Sep 8, 2025
Member
|
Merging based on Dheeraj's approval too |
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice, thanks for the flushSync fix 🎉.
Here is a follow up PR to include that by default to the bootstrapping tool.
#55451
78 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-( ``` error: Authentication error: Authentication required: You must have push access to verify locks error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' ``` ...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR? The last commit [Rework maintenance dialog to be a dialog](apache@7e6d13c) has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful: ``` Uncaught TypeError: can't access property "flushSync", ne is undefined R http://localhost:28080/edge_worker/static/main.umd.cjs:16 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dheerajturaga somehow I was not able to pugh to your repo directly git gave me an error :-(
...anyway, another way around, openeing a draft PR here, can you cherry-pick the commits down to your PR?
The last commit Rework maintenance dialog to be a dialog has a problem though: Dialog is not opening, it makes a JS script error which is not much helpful:
UPDATE: THANKS to @shubhamraj-git - your proposal fixed it! Finally "beautifil" UI is now coming-up with: