Skip to content

Display responder username for better audit. #55509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierrejeambrun merged 2 commits into from
Sep 15, 2025
Merged

Display responder username for better audit. #55509

pierrejeambrun merged 2 commits into from
Sep 15, 2025

Conversation

@tirkarthi
Copy link
Contributor

@tirkarthi tirkarthi commented Sep 11, 2025

When responder username is not the default value then display it with response received timestamp for better audit.

closes #55033

image

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 11, 2025
@Lee-W
Copy link
Member

Lee-W commented Sep 11, 2025

Hey, thanks for opening this. I'm now working on #55463 which might change the columns a bit

@Lee-W Lee-W self-requested a review September 11, 2025 14:28
@Lee-W Lee-W added this to the Airflow 3.1.0 milestone Sep 11, 2025
@Lee-W Lee-W moved this to In review in AIP-90 - Human in the loop Sep 11, 2025
@tirkarthi
Copy link
Contributor Author

tirkarthi commented Sep 11, 2025

Thanks @Lee-W for the heads up. If I understand correctly, the draft PR is to rename responded_user_name to responded_by_user_name but I will wait for the final version to be merge to update this PR.

@Lee-W
Copy link
Member

Lee-W commented Sep 11, 2025

Thanks @Lee-W for the heads up. If I understand correctly, the draft PR is to rename responded_user_name to responded_by_user_name but I will wait for the final version to be merge to update this PR.

It'll become responded_by_user.name instead

@bbovenzi
Copy link
Contributor

bbovenzi commented Sep 11, 2025

Let's wait for Wei's changes and then rebase.

@Lee-W
Copy link
Member

Lee-W commented Sep 11, 2025

#55536

I'm now removing the hard-coded default user

@tirkarthi
Copy link
Contributor Author

tirkarthi commented Sep 13, 2025

I have rebased on main and updated the code.

@pierrejeambrun pierrejeambrun merged commit 36ae381 into apache:main Sep 15, 2025
56 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AIP-90 - Human in the loop Sep 15, 2025
kaxil pushed a commit that referenced this pull request Sep 15, 2025
@tirkarthi @kaxil
Display responder username for better audit. (#55509)
b7c5828 
* Display responder username for better audit.

* Update response object changes.

(cherry picked from commit 36ae381)
yash1thsa pushed a commit to yash1thsa/airflow that referenced this pull request Sep 16, 2025
@tirkarthi @yash1thsa
Display responder username for better audit. (apache#55509)
4961015 
* Display responder username for better audit.

* Update response object changes.
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
@tirkarthi @suman-himanshu
Display responder username for better audit. (apache#55509)
52c999c 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
fa35e58 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
1c691bf 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
0c02bda 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
992aaa6 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
37094ea 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
1e8dc2c 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
17a4e1c 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
05ab769 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
31b3ae2 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
e827139 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
2538d37 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
4f6c882 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
97c53df 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
3509124 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
447dcdb 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
578eaa8 
* Display responder username for better audit.

* Update response object changes.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
@tirkarthi
Display responder username for better audit. (apache#55509)
083947b 
* Display responder username for better audit.

* Update response object changes.
@potiuk potiuk mentioned this pull request Nov 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

@Lee-W Lee-W Awaiting requested review from Lee-W

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

AIP-90 - Human in the loop
Status: Done

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

Add respondent name to HITL detail response details in UI

5 participants

@tirkarthi @Lee-W @bbovenzi @uranusjr @pierrejeambrun